Skip to content

Fix blog CTA button text not displaying #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RoyEJohnson merged 4 commits into from
Jan 8, 2026
Merged

Fix blog CTA button text not displaying #2812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8a1b51
Fix blog CTA button text not displaying
OpenStaxClaude Jan 8, 2026
1e68a4a
Fix blog CTA button by using camelCase field names
OpenStaxClaude Jan 8, 2026
903567d
Update test to use camelCase field names for CTA button
OpenStaxClaude Jan 8, 2026
58fe530
Update test data to use camelCase field names
OpenStaxClaude Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/app/components/body-units/body-units.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ type CTAData = {
alignment: string;
heading: string;
description: string;
button_href: string;
button_text: string;
buttonHref: string;
buttonText: string;
};

function CTA({data}: {data: CTAData}) {
Expand All @@ -28,8 +28,8 @@ function CTA({data}: {data: CTAData}) {
<div className={`blog-cta ${alignment}`}>
<h2>{data.heading}</h2>
<div>{data.description}</div>
<a className="btn primary" href={data.button_href}>
{data.button_text}
<a className="btn primary" href={data.buttonHref}>
{data.buttonText}
</a>
</div>
);
Expand Down
5 changes: 2 additions & 3 deletions test/src/components/body-units.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,15 @@ describe('body-units', () => {
screen.getByText('terrible mistake', {exact: false});
});
it('handles CTA', () => {
/* eslint-disable camelcase */
const unit: UnitType = {
id: 'meh',
type: 'blog_cta',
value: {
alignment: 'left',
heading: 'Heading',
description: 'description text',
button_href: '#',
button_text: 'click me'
buttonHref: '#',
buttonText: 'click me'
}
};

Expand Down
4 changes: 2 additions & 2 deletions test/src/data/article-page-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ export default {
alignment: 'left',
heading: 'Heading',
description: 'description text',
button_href: '#',
button_text: 'click me'
buttonHref: '#',
buttonText: 'click me'
}
},
{
Expand Down