Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decision tree for FM in fine_mapper #764

Closed
wants to merge 6 commits into from

Conversation

Daniel-Considine
Copy link
Contributor

@Daniel-Considine Daniel-Considine commented Sep 16, 2024

✨ Context

Currently we aren't filtering out loci with too few loci prior to fine-mapping

🛠 What does this PR implement

After the join between summary statistics and LD index, if there are less than 100 variants an error is logged and the locus is not fine-mapped.

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

Copy link
Contributor

@addramir addramir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the logic and I agree we should keep the filtering in function, not init function as I suggested before.

  1. These changes should be merged to new function with LD interface
  2. We need to add the same case but for extremely large number of variants, I suggest 15K

@addramir addramir changed the title feat: filter study loci with less than 100 variants feat: filter study loci with less than 100 variants or more than 15K Sep 20, 2024
@github-actions github-actions bot added size-M and removed size-XS labels Sep 25, 2024
@addramir addramir changed the title feat: filter study loci with less than 100 variants or more than 15K feat: decision tree for FM in fine_mapper Sep 25, 2024
@addramir addramir marked this pull request as draft September 25, 2024 10:27
@addramir addramir closed this Oct 17, 2024
@Daniel-Considine Daniel-Considine deleted the dc_locus_fm_filter branch November 11, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants