-
Notifications
You must be signed in to change notification settings - Fork 1.9k
CI: Add CentOS Stream 9/10 to the FULL_OS runner list #17526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@behlendorf I noticed that the CI run for this PR seems to have used the QUICK_OS list, not the FULL_OS list. Would it be appropriate to add CentOS Stream 9 and 10 to the QUICK_OS list as well? |
@carlwgeorge the QUICK_OS gets used when the CI determines the PR doesn't have any ZFS code changes. So it worked properly here, and we wouldn't want to add the new runners to the QUICK_OS list. You should be able to force a full run by adding "ZFS-CI-Type: full" to your commit message and force updating the PR. |
I think this may have already identified a change in the RHEL 9.7 and 10.1 kernels that will be a problem for the kmods for those minor versions down the road. On Alma 9:
On CentOS Stream 9:
Similar output can be observed for version 10 of each. Is it possibly that something is wrong with the generation of |
Does |
I had a look, the wrapper seem to get created
I'd need access to the filesystem of the runner to root cause the failure. |
A case of an old kernel with backported never changes. See #17541 for a proposed fix. |
@AttilaFueloep thanks for the fix, it looks good. @carlwgeorge would you mind rebasing this against the latest master branch which includes #17541. |
Testing on CentOS Stream provides several months advance notice of changes coming to the RHEL kernel. This should help OpenZFS be proactive instead of reactive to new RHEL minor versions. Related openzfs#16904 ZFS-CI-Type: full Signed-off-by: Carl George <[email protected]>
Rebased, and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It'll be nice to have a little more reliable warning about any potential incoming breakage.
Motivation and Context
Testing on CentOS Stream provides several months advance notice of changes coming to the RHEL kernel. This should help OpenZFS be proactive instead of reactive to new RHEL minor versions.
Description
I partially reverted the changes in #16904 which made CentOS Stream 9 an optional runner, and added CentOS Stream 10 to the FULL_OS runner list.
How Has This Been Tested?
As this is a change to the CI itself, I'd like the CI run on this PR to serve as the testing.
Types of changes
Checklist:
Signed-off-by
.