Skip to content

objtool wrapper: use absolute path to call the wrapper. #17541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AttilaFueloep
Copy link
Contributor

@AttilaFueloep AttilaFueloep commented Jul 13, 2025

Motivation and Context

Older kernel versions run make outside of the build directory. This works since all paths are absolute. Relative paths will fail in such a scenario. See #17526. Follow-up for #17456.

Description

Use an absolute path to the objtool wrapper as well, since the relative path breaks the build on older kernels.

How Has This Been Tested?

CI run on local repo.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Older kernel versions run make outside of the build directory. This
works since all paths are absolute. Relative paths will fail in such
a scenario.

Use an absolute path to the objtool wrapper as well, since the
relative path breaks the build on older kernels.

Signed-off-by: Attila Fülöp <[email protected]>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Jul 14, 2025
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 14, 2025
@behlendorf behlendorf merged commit 8de8e0d into openzfs:master Jul 14, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants