Skip to content

AO3-6268 Fix All challenge owners/moderators get CCed in "Assignments sent" notification #1281

AO3-6268 Fix All challenge owners/moderators get CCed in "Assignments sent" notification

AO3-6268 Fix All challenge owners/moderators get CCed in "Assignments sent" notification #1281

Status Failure
Total duration 1m 47s
Artifacts

reviewdog.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 10 warnings
Rubocop
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
Rubocop
Process completed with exit code 1.
Rubocop: app/mailers/user_mailer.rb#L34
[rubocop] reported by reviewdog 🐶 Prefer string interpolation to string concatenation. Raw Output: app/mailers/user_mailer.rb:34:52: C: Style/StringConcatenation: Prefer string interpolation to string concatenation.
Rubocop: app/mailers/user_mailer.rb#L35
[rubocop] reported by reviewdog 🐶 Indent `)` to column 4 (not 7) Raw Output: app/mailers/user_mailer.rb:35:8: C: Layout/ClosingParenthesisIndentation: Indent `)` to column 4 (not 7)
Rubocop: app/models/challenge_assignment.rb#L19
[rubocop] reported by reviewdog 🐶 Use `.exclude?` and remove the negation part. Raw Output: app/models/challenge_assignment.rb:19:8: C: Rails/NegateInclude: Use `.exclude?` and remove the negation part.
Rubocop: app/models/challenge_assignment.rb#L24
[rubocop] reported by reviewdog 🐶 Use `where(request_signup_id: signup.id)` instead of manually constructing SQL. Raw Output: app/models/challenge_assignment.rb:24:43: C: Rails/WhereEquals: Use `where(request_signup_id: signup.id)` instead of manually constructing SQL.
Rubocop: app/models/challenge_assignment.rb#L26
[rubocop] reported by reviewdog 🐶 Use `where(offer_signup_id: signup.id)` instead of manually constructing SQL. Raw Output: app/models/challenge_assignment.rb:26:41: C: Rails/WhereEquals: Use `where(offer_signup_id: signup.id)` instead of manually constructing SQL.
Rubocop: app/models/challenge_assignment.rb#L28
[rubocop] reported by reviewdog 🐶 Use `where(challenge_assignments: { collection_id: collection.id })` instead of manually constructing SQL. Raw Output: app/models/challenge_assignment.rb:28:42: C: Rails/WhereEquals: Use `where(challenge_assignments: { collection_id: collection.id })` instead of manually constructing SQL.
Rubocop: app/models/challenge_assignment.rb#L61
[rubocop] reported by reviewdog 🐶 Use `where(users: { id: user.id })` instead of manually constructing SQL. Raw Output: app/models/challenge_assignment.rb:61:8: C: Rails/WhereEquals: Use `where(users: { id: user.id })` instead of manually constructing SQL.
Rubocop: app/models/challenge_assignment.rb#L69
[rubocop] reported by reviewdog 🐶 Freeze mutable objects assigned to constants. Raw Output: app/models/challenge_assignment.rb:69:32: C: Style/MutableConstant: Freeze mutable objects assigned to constants.
Rubocop: app/models/challenge_assignment.rb#L154
[rubocop] reported by reviewdog 🐶 Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.xmlschema`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.httpdate`, `Time.now.to_i`, `Time.now.to_f` instead. Raw Output: app/models/challenge_assignment.rb:154:31: C: Rails/TimeZone: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.xmlschema`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.httpdate`, `Time.now.to_i`, `Time.now.to_f` instead.
Rubocop: app/models/challenge_assignment.rb#L214
[rubocop] reported by reviewdog 🐶 Use safe navigation (`&.`) instead of checking if an object exists before calling the method. Raw Output: app/models/challenge_assignment.rb:214:8: C: Style/SafeNavigation: Use safe navigation (`&.`) instead of checking if an object exists before calling the method.