AO3-6777 Fix that tag names could be blank #4892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilka2
force-pushed
the
AO3-6777-blank-tag-zero-width-space
branch
from
5bc5f4f
to
832764b
Compare
brianjaustin
reviewed
Aug 6, 2024
brianjaustin
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6777
Purpose
Forbid tag names that consist exclusively of Unicode characters from the format category because they end up looking blank.
Testing Instructions
See Jira.
References
This validation is based on the fact that AO3-6087 created this bug by no longer stripping these characters from tag names.
Credit
Bilka (he/him)