AO3-6760 Check admin roles in UnsortedTagsController #4903
+126
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilka2
reviewed
Sep 13, 2024
| @@ -5,13 +5,17 @@ class UnsortedTagsController < ApplicationController | |||
| before_action :check_permission_to_wrangle | |||
|
|
|||
| def index | |||
| authorize :wrangling if logged_in_as_admin? | |||
There was a problem hiding this comment.
I think it would be good to use view_access? directly here instead of going via the action because index is one of the actions where the various wrangling related controllers have different access levels.
That way the index? alias can be removed and we won't have someone accidentally converting e.g. TagWranglersController to using the index? permission and giving more roles access than intended.
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Issue
https://otwarchive.atlassian.net/browse/AO3-6760
Purpose
Restricts access to the Unsorted Tags bin to
superadmin,policy_and_abuse, andtag_wranglingadmins. For the PAC admins, view-only access is allowed; the other two roles have full (view/edit) access.