AO3-6761 Check admin roles in TagWranglingsController

[brianjaustin]

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6758

Purpose

Restrict access to PAC (tag bins only) and wrangling/super admins (wrangling tools, mass update)

References

This is probably going to cause conflicts with #4917; please merge that one first if this is in the same release, then I will fix the conflicts.

[brianjaustin]

I noticed that "Wrangling Tools" in the left-hand navigation menu is selected, even when on mass wranglings page:

Do we want to hide the 'Wrangling Tools" item (which is not selectable) for any admin who does not have access to the general wrangling tools page?

[sarken]

Huh, that's weird. Just to clarify because I can't pull the code right now: if you're on, e.g., https://test.archiveofourown.org/tag_wranglings?show=fandoms with this new code, "Wrangling Tools" is is a span instead of a link? Is this for all admins or just admins who can't access Wrangling Tools?

Regardless, I think the fix for that might be changing the link in the sidebar to explicitly check that the params are blank.

otwarchive/app/views/tag_wranglings/_wrangler_dashboard.html.erb

Line 6 in f607097

<li><%= span_if_current(ts('Wrangling Tools'), tag_wranglings_path) %></li>

 <li><%= span_if_current(ts('Wrangling Tools'), tag_wranglings_path, params[:show].blank?) %></li> 

(It's possible there's more than one version of this sidebar.)

[brianjaustin]

@sarken that's actually the case now, not just with the new code... 😬 I don't object to fixing it here, but the main question I had was if we should hide that part of the menu for non-write admins (iirc the ticket doesn't say either way)

[sarken]

Ah, okay! I thought it was a new bug, and you were asking if the way to deal with it was to hide that particular link while leaving the others visible.

I think we can leave the full sidebar visible for anyone with either type of access and just stick to this plan from AO3-6758 for everyone else:

The final pull request will need to hide the major navigational elements:

• the “Tag Wrangling” item in the admin navigation from all admin roles except superadmin, policy_and_abuse, and tag_wrangling
• the sidebar on https://test.archiveofourown.org/tags/search and https://test.archiveofourown.org/tags/testing from all admin roles except superadmin and tag_wrangling

[sarken]

(Feel free to fix or make a new issue for the span_if_current thing as desired!)

[Bilka2]

Should there be a test for the navbar visibility?

I think it would be nice if you could i18n the wrangler_dashboard, none of the other pull requests touched it so hopefully it shouldn't lead to merge conflicts.

[Bilka2]

Thank you!

[Bilka2]

🤔 I thought this needed to be read_access? as well but the tests pass without it? Maybe still good to change though so it's not confusing?

[Bilka2]

I see, it doesn't show on the tags index page, because that one doesn't have @counts set. So this should be changed and the tests should all start out in the tags index, not the tag wrangling tools