Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6834 Add Parent Thread link to unreviewed comments #4956

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

minionluvr
Copy link

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6834

Purpose

Made changes so that when an unreviewed comment is a reply, a Parent Thread link is available. This gives the reviewer context for approval.
The changes in this PR only add the link to the Parent Thread, not the parent comment (the 'commentable'/specific comment being replied to), so there can still be some confusion in the case where the unreviewed comment is a deeply nested reply in some thread.

Testing Instructions

Refer to Jira Issue. I added a scenario for testing.

Credit

minionluvr (she/her)

Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, minionluvr!

Thank you for working on this! The changes look good to me with 1 comment, once that's resolved I can approve the PR. In the meantime, I've updated the Jira issue status to In Review, so no one will mistakenly create a duplicate pull request.

If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! You can just reply here with the account name and we'll set up the permissions for you. (It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME).")

Thanks again for contributing! If you have any questions, you can contact us at [email protected].

When I am logged in as "author"
And I view the work "Moderation"
And I follow "Unreviewed Comments (1)"
Then I should not see "Parent Thread"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a trailing line here? For a few reasons (https://stackoverflow.com/a/5813359 and a few of the other answers there), it's better to have it than not. If you use VS Code, that can do it for you automatically: https://stackoverflow.com/a/44704969

Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants