Add APOB messages to host_sp_comms #2006
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
reviewed
Feb 7, 2025
| hf.bonus_sector_erase(offset) | ||
| .map_err(|err| APOBError::EraseFailed { offset, err })?; | ||
| } else { | ||
| // Read back the page and confirm that it's all empty |
There was a problem hiding this comment.
Could this fail if there's a blip in the IPCC path and the host resends an APOB request? (I'm not sure what the expectations are for the offsets the host is providing.)
hawkw
reviewed
Feb 7, 2025
Aaron-Hartwig
force-pushed
the
mkeeter/ipcc-apob
branch
from
3c34974 to
593980a
Compare
citrus-it
force-pushed
the
mkeeter/ipcc-apob
branch
from
65a65da to
ebcfe39
Compare
citrus-it
force-pushed
the
mkeeter/ipcc-apob
branch
from
ded20cd to
7846e44
Compare
rmustacc
reviewed
Aug 29, 2025
Comment on lines
+1079
to
+1083
| fn apob_write( | ||
| hf: &HostFlash, | ||
| mut offset: u64, | ||
| data: &[u8], | ||
| ) -> Result<(), ApobError> { |
There was a problem hiding this comment.
So we need something in the broader API to discover what the erase size granularity is or at least make sure that we're sending stuff that is page size aligned. This gets to what @jgallagher gets at below. But if the host sent things that wasn't page aligned then we'd erase the entire page because our API is not doing a read-modify-write.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/oxidecomputer/stlouis/issues/707, https://github.com/oxidecomputer/rfd/pull/855 , oxidecomputer/amd-host-image-builder#222