feat: Add compatibility for Facebook Login SDK 17.x #1225
Conversation
|
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughThe version constraint for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
facebook/build.gradle(1 hunks)
🔇 Additional comments (1)
facebook/build.gradle (1)
6-35: Confirm SDK/compileSdk compatibility with Facebook Login 17.xFacebook Login 17.x bumps its
compileSdkVersionrequirement to 34 and raises the min version of several transitive AndroidX libs. Our module still inheritscompileSdkVersion rootProject.ext.compileSdkVersion; if the root project is <34 the build will now fail. Likewise ensureandroidx.browser&androidx.annotationtransitive versions don’t clash with other modules.Please verify the build matrix locally and in CI against all supported
compileSdk& device API levels before merging.Also applies to: 38-45
| @@ -35,7 +35,7 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| api "com.facebook.android:facebook-login:[13.2.0, 17.0.0[" | |||
| api "com.facebook.android:facebook-login:[13.2.0, 18.0.0[" | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Dynamic range [13.2.0, 18.0.0[ can break reproducibility & CI caching
Extending the upper bound to <18.0.0 is fine for 17.x support, but the open-ended patch and minor range still leaves builds picking up whichever 17.x.y happens to be latest at resolution time. That can:
• silently change byte-code & behaviour without a code change
• invalidate Gradle caches across CI agents
• complicate reproducible builds / security SBOMs
Consider pinning to the highest validated version (e.g. 17.0.2) or using a version catalog/BOM so upgrades are an explicit commit rather than an implicit side-effect.
- api "com.facebook.android:facebook-login:[13.2.0, 18.0.0["
+ api "com.facebook.android:facebook-login:17.0.2" // or whatever is currently qualified📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| api "com.facebook.android:facebook-login:[13.2.0, 18.0.0[" | |
| api "com.facebook.android:facebook-login:17.0.2" // or whatever is currently qualified |
🤖 Prompt for AI Agents
In facebook/build.gradle at line 38, the dependency version range
"com.facebook.android:facebook-login:[13.2.0, 18.0.0[" uses an open-ended range
that can cause non-reproducible builds by picking the latest 17.x.y version at
build time. To fix this, replace the dynamic range with a fixed version pinned
to the highest validated version, such as "17.0.2", or manage versions
explicitly using a version catalog or BOM to ensure consistent and reproducible
builds.
Summary by CodeRabbit