Skip to content

feat: Add compatibility for Facebook Login SDK 17.x #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add compatibility for Facebook Login SDK 17.x #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion facebook/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ android {
}

dependencies {
api "com.facebook.android:facebook-login:[13.2.0, 17.0.0["
api "com.facebook.android:facebook-login:[13.2.0, 18.0.0["
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Dynamic range [13.2.0, 18.0.0[ can break reproducibility & CI caching

Extending the upper bound to <18.0.0 is fine for 17.x support, but the open-ended patch and minor range still leaves builds picking up whichever 17.x.y happens to be latest at resolution time. That can:

• silently change byte-code & behaviour without a code change
• invalidate Gradle caches across CI agents
• complicate reproducible builds / security SBOMs

Consider pinning to the highest validated version (e.g. 17.0.2) or using a version catalog/BOM so upgrades are an explicit commit rather than an implicit side-effect.

-    api "com.facebook.android:facebook-login:[13.2.0, 18.0.0["
+    api "com.facebook.android:facebook-login:17.0.2"  // or whatever is currently qualified
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
api "com.facebook.android:facebook-login:[13.2.0, 18.0.0["
api "com.facebook.android:facebook-login:17.0.2" // or whatever is currently qualified
🤖 Prompt for AI Agents 
In facebook/build.gradle at line 38, the dependency version range
"com.facebook.android:facebook-login:[13.2.0, 18.0.0[" uses an open-ended range
that can cause non-reproducible builds by picking the latest 17.x.y version at
build time. To fix this, replace the dynamic range with a fixed version pinned
to the highest validated version, such as "17.0.2", or manage versions
explicitly using a version catalog or BOM to ensure consistent and reproducible
builds.

implementation project(":parse")

testImplementation "junit:junit:$rootProject.ext.junitVersion"
Expand Down
Loading