Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-31778) feat(Bookings): post reaction on tab change or on change screen #6909

Merged
merged 7 commits into from
Sep 23, 2024
Merged

(PC-31778) feat(Bookings): post reaction on tab change or on change screen #6909

merged 7 commits into from
Sep 23, 2024

Conversation

yleclercq-pass
Copy link
Contributor

@yleclercq-pass yleclercq-pass commented Sep 20, 2024 •
edited
Loading

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-31778

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

Enregistrement.de.l.ecran.2024-09-20.a.15.38.13.mov

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

Performance Comparison Report

Significant Changes To Render Duration

Name Render Duration Render Count
Performance test for Bookings page 45.3 ms → 62.3 ms (+17.0 ms, +37.5%) 🔴🔴 7 → 9 (+2, +28.6%) 🔴🔴
Performance test for Offer page 178.4 ms → 171.1 ms (-7.3 ms, -4.1%) 4 → 4
Show details
Name Render Duration Render Count
Performance test for Bookings page Baseline
Mean: 45.3 ms
Stdev: 1.4 ms (3.1%)
Runs: 47 47 47 46 45 45 45 44 44 43

Current
Mean: 62.3 ms
Stdev: 2.4 ms (3.9%)
Runs: 66 65 64 63 63 62 61 61 60 58		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9
Performance test for Offer page Baseline
Mean: 178.4 ms
Stdev: 7.1 ms (4.0%)
Runs: 189 185 183 183 181 179 175 172 169 168

Current
Mean: 171.1 ms
Stdev: 4.0 ms (2.3%)
Runs: 177 176 176 172 170 170 169 167 167 167		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for Favorites page 64.4 ms → 64.7 ms (+0.3 ms, ±0.0%) 6 → 6
Performance test for Venue page 2.5 ms → 2.3 ms (-0.2 ms, -8.0%) 1 → 1
Search Landing Page - Performance test for Search Landing page 14.3 ms → 14.1 ms (-0.2 ms, -1.4%) 5 → 5
Performance test for Profile page 7.1 ms → 6.6 ms (-0.5 ms, -7.0%) 5 → 5.70 (+0.7000000000000002, +14.0%) 🔴
Search Results - Performance test for Search Results page 14.8 ms → 14.2 ms (-0.6 ms, -4.1%) 5 → 5
Performance test for EndedBookings page 33.9 ms → 30.2 ms (-3.7 ms, -10.9%) 7 → 6 (-1, -14.3%) 🟢
Show details
Name Render Duration Render Count
Performance test for Favorites page Baseline
Mean: 64.4 ms
Stdev: 2.0 ms (3.1%)
Runs: 67 67 66 65 65 64 64 63 62 61

Current
Mean: 64.7 ms
Stdev: 1.8 ms (2.7%)
Runs: 68 66 66 65 65 65 64 63 63 62		 Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Venue page Baseline
Mean: 2.5 ms
Stdev: 0.5 ms (21.1%)
Runs: 3 3 3 3 3 2 2 2 2 2

Current
Mean: 2.3 ms
Stdev: 0.5 ms (21.0%)
Runs: 3 3 3 2 2 2 2 2 2 2		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 14.3 ms
Stdev: 2.4 ms (16.8%)
Runs: 18 17 16 16 15 13 13 12 12 11

Current
Mean: 14.1 ms
Stdev: 1.8 ms (12.7%)
Runs: 16 16 16 15 15 14 13 13 12 11		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Profile page Baseline
Mean: 7.1 ms
Stdev: 0.9 ms (12.3%)
Runs: 8 8 8 7 7 7 7 7 7 5

Current
Mean: 6.6 ms
Stdev: 1.1 ms (16.3%)
Runs: 8 8 8 7 6 6 6 6 6 5		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5.70
Stdev: 2.21 (38.8%)
Runs: 12 5 5 5 5 5 5 5 5 5
Search Results - Performance test for Search Results page Baseline
Mean: 14.8 ms
Stdev: 1.4 ms (9.4%)
Runs: 17 16 16 16 15 14 14 14 13 13

Current
Mean: 14.2 ms
Stdev: 1.3 ms (9.3%)
Runs: 16 16 15 15 14 14 14 13 13 12		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page Baseline
Mean: 33.9 ms
Stdev: 2.5 ms (7.3%)
Runs: 37 36 36 35 35 34 34 32 30 30

Current
Mean: 30.2 ms
Stdev: 1.4 ms (4.6%)
Runs: 32 32 31 31 31 30 29 29 29 28		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Changes To Render Count

Name Render Duration Render Count
Performance test for Bookings page 45.3 ms → 62.3 ms (+17.0 ms, +37.5%) 🔴🔴 7 → 9 (+2, +28.6%) 🔴🔴
Performance test for Profile page 7.1 ms → 6.6 ms (-0.5 ms, -7.0%) 5 → 5.70 (+0.7000000000000002, +14.0%) 🔴
Performance test for EndedBookings page 33.9 ms → 30.2 ms (-3.7 ms, -10.9%) 7 → 6 (-1, -14.3%) 🟢
Show details
Name Render Duration Render Count
Performance test for Bookings page Baseline
Mean: 45.3 ms
Stdev: 1.4 ms (3.1%)
Runs: 47 47 47 46 45 45 45 44 44 43

Current
Mean: 62.3 ms
Stdev: 2.4 ms (3.9%)
Runs: 66 65 64 63 63 62 61 61 60 58		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9
Performance test for Profile page Baseline
Mean: 7.1 ms
Stdev: 0.9 ms (12.3%)
Runs: 8 8 8 7 7 7 7 7 7 5

Current
Mean: 6.6 ms
Stdev: 1.1 ms (16.3%)
Runs: 8 8 8 7 6 6 6 6 6 5		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5.70
Stdev: 2.21 (38.8%)
Runs: 12 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page Baseline
Mean: 33.9 ms
Stdev: 2.5 ms (7.3%)
Runs: 37 36 36 35 35 34 34 32 30 30

Current
Mean: 30.2 ms
Stdev: 1.4 ms (4.6%)
Runs: 32 32 31 31 31 30 29 29 29 28		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against f082255

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@yleclercq-pass yleclercq-pass merged commit 29ace50 into master Sep 23, 2024
51 of 52 checks passed
@yleclercq-pass yleclercq-pass deleted the PC-31778 branch September 23, 2024 07:49
xlecunff-pass pushed a commit that referenced this pull request Sep 29, 2024
@yleclercq-pass @xlecunff-pass
(PC-31778) feat(Bookings): post reaction on tab change or on change s…
0a2545e 
…creen (#6909)

* (PC-31778) feat(api): update api file

* (PC-31778) feat(TabLayout): adapt tabLayout on change

* (PC-31778) feat(EndedBookings): adapt types with new post reaction

* (PC-31778) feat(Bookings): post reaction on tab change or on change screen

* (PC-31778) fix(EndedBookings): fix test

* (PC-31778) fix types

* (PC-31778) refacto wording after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmeissonnier-pass mmeissonnier-pass mmeissonnier-pass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yleclercq-pass @mmeissonnier-pass