(PC-31778) feat(Bookings): post reaction on tab change or on change screen #6909

YassinL · 2024-09-20T13:16:26Z

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-31778

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

Made sure my feature is working on web.
Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
Written unit tests native (and web when implementation is different) for my feature.
Added a screenshot for UI tickets or deleted the screenshot section if no UI change
If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

Enregistrement.de.l.ecran.2024-09-20.a.15.38.13.mov

…creen

github-actions · 2024-09-20T13:41:12Z

Performance Comparison Report

Current: HEAD (58edd55)
Baseline: master (b04ceba)

Significant Changes To Render Duration

Name	Render Duration	Render Count
Performance test for Bookings page	45.3 ms → 62.3 ms (+17.0 ms, +37.5%) 🔴🔴	7 → 9 (+2, +28.6%) 🔴🔴
Performance test for Offer page	178.4 ms → 171.1 ms (-7.3 ms, -4.1%)	4 → 4

Show details

Name	Render Duration	Render Count
Performance test for Bookings page	Baseline Mean: 45.3 ms Stdev: 1.4 ms (3.1%) Runs: 47 47 47 46 45 45 45 44 44 43 Current Mean: 62.3 ms Stdev: 2.4 ms (3.9%) Runs: 66 65 64 63 63 62 61 61 60 58	Baseline Mean: 7 Stdev: 0 (0.0%) Runs: 7 7 7 7 7 7 7 7 7 7 Current Mean: 9 Stdev: 0 (0.0%) Runs: 9 9 9 9 9 9 9 9 9 9
Performance test for Offer page	Baseline Mean: 178.4 ms Stdev: 7.1 ms (4.0%) Runs: 189 185 183 183 181 179 175 172 169 168 Current Mean: 171.1 ms Stdev: 4.0 ms (2.3%) Runs: 177 176 176 172 170 170 169 167 167 167	Baseline Mean: 4 Stdev: 0 (0.0%) Runs: 4 4 4 4 4 4 4 4 4 4 Current Mean: 4 Stdev: 0 (0.0%) Runs: 4 4 4 4 4 4 4 4 4 4

Meaningless Changes To Render Duration

Show entries

Name	Render Duration	Render Count
Performance test for Favorites page	64.4 ms → 64.7 ms (+0.3 ms, ±0.0%)	6 → 6
Performance test for Venue page	2.5 ms → 2.3 ms (-0.2 ms, -8.0%)	1 → 1
Search Landing Page - Performance test for Search Landing page	14.3 ms → 14.1 ms (-0.2 ms, -1.4%)	5 → 5
Performance test for Profile page	7.1 ms → 6.6 ms (-0.5 ms, -7.0%)	5 → 5.70 (+0.7000000000000002, +14.0%) 🔴
Search Results - Performance test for Search Results page	14.8 ms → 14.2 ms (-0.6 ms, -4.1%)	5 → 5
Performance test for EndedBookings page	33.9 ms → 30.2 ms (-3.7 ms, -10.9%)	7 → 6 (-1, -14.3%) 🟢

Show details

Name	Render Duration	Render Count
Performance test for Favorites page	Baseline Mean: 64.4 ms Stdev: 2.0 ms (3.1%) Runs: 67 67 66 65 65 64 64 63 62 61 Current Mean: 64.7 ms Stdev: 1.8 ms (2.7%) Runs: 68 66 66 65 65 65 64 63 63 62	Baseline Mean: 6 Stdev: 0 (0.0%) Runs: 6 6 6 6 6 6 6 6 6 6 Current Mean: 6 Stdev: 0 (0.0%) Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Venue page	Baseline Mean: 2.5 ms Stdev: 0.5 ms (21.1%) Runs: 3 3 3 3 3 2 2 2 2 2 Current Mean: 2.3 ms Stdev: 0.5 ms (21.0%) Runs: 3 3 3 2 2 2 2 2 2 2	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1
Search Landing Page - Performance test for Search Landing page	Baseline Mean: 14.3 ms Stdev: 2.4 ms (16.8%) Runs: 18 17 16 16 15 13 13 12 12 11 Current Mean: 14.1 ms Stdev: 1.8 ms (12.7%) Runs: 16 16 16 15 15 14 13 13 12 11	Baseline Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5 Current Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Profile page	Baseline Mean: 7.1 ms Stdev: 0.9 ms (12.3%) Runs: 8 8 8 7 7 7 7 7 7 5 Current Mean: 6.6 ms Stdev: 1.1 ms (16.3%) Runs: 8 8 8 7 6 6 6 6 6 5	Baseline Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5 Current Mean: 5.70 Stdev: 2.21 (38.8%) Runs: 12 5 5 5 5 5 5 5 5 5
Search Results - Performance test for Search Results page	Baseline Mean: 14.8 ms Stdev: 1.4 ms (9.4%) Runs: 17 16 16 16 15 14 14 14 13 13 Current Mean: 14.2 ms Stdev: 1.3 ms (9.3%) Runs: 16 16 15 15 14 14 14 13 13 12	Baseline Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5 Current Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page	Baseline Mean: 33.9 ms Stdev: 2.5 ms (7.3%) Runs: 37 36 36 35 35 34 34 32 30 30 Current Mean: 30.2 ms Stdev: 1.4 ms (4.6%) Runs: 32 32 31 31 31 30 29 29 29 28	Baseline Mean: 7 Stdev: 0 (0.0%) Runs: 7 7 7 7 7 7 7 7 7 7 Current Mean: 6 Stdev: 0 (0.0%) Runs: 6 6 6 6 6 6 6 6 6 6

Changes To Render Count

Name	Render Duration	Render Count
Performance test for Bookings page	45.3 ms → 62.3 ms (+17.0 ms, +37.5%) 🔴🔴	7 → 9 (+2, +28.6%) 🔴🔴
Performance test for Profile page	7.1 ms → 6.6 ms (-0.5 ms, -7.0%)	5 → 5.70 (+0.7000000000000002, +14.0%) 🔴
Performance test for EndedBookings page	33.9 ms → 30.2 ms (-3.7 ms, -10.9%)	7 → 6 (-1, -14.3%) 🟢

Show details

Name	Render Duration	Render Count
Performance test for Bookings page	Baseline Mean: 45.3 ms Stdev: 1.4 ms (3.1%) Runs: 47 47 47 46 45 45 45 44 44 43 Current Mean: 62.3 ms Stdev: 2.4 ms (3.9%) Runs: 66 65 64 63 63 62 61 61 60 58	Baseline Mean: 7 Stdev: 0 (0.0%) Runs: 7 7 7 7 7 7 7 7 7 7 Current Mean: 9 Stdev: 0 (0.0%) Runs: 9 9 9 9 9 9 9 9 9 9
Performance test for Profile page	Baseline Mean: 7.1 ms Stdev: 0.9 ms (12.3%) Runs: 8 8 8 7 7 7 7 7 7 5 Current Mean: 6.6 ms Stdev: 1.1 ms (16.3%) Runs: 8 8 8 7 6 6 6 6 6 5	Baseline Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5 Current Mean: 5.70 Stdev: 2.21 (38.8%) Runs: 12 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page	Baseline Mean: 33.9 ms Stdev: 2.5 ms (7.3%) Runs: 37 36 36 35 35 34 34 32 30 30 Current Mean: 30.2 ms Stdev: 1.4 ms (4.6%) Runs: 32 32 31 31 31 30 29 29 29 28	Baseline Mean: 7 Stdev: 0 (0.0%) Runs: 7 7 7 7 7 7 7 7 7 7 Current Mean: 6 Stdev: 0 (0.0%) Runs: 6 6 6 6 6 6 6 6 6 6

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against f082255

src/features/bookings/pages/Bookings/Bookings.tsx

mmeissonnier-pass · 2024-09-20T14:22:39Z

src/features/bookings/pages/Bookings/Bookings.tsx

+    useCallback(() => {
+      return () => {
+        if (previousTab === Tab.COMPLETED) {
+          updateReactions()


J'ai toujours du mal à comprendre comment ceci peut fonctionner juste en changeant d'onglet sans quitter la page 🤔

EDIT : ayé j'ai compris --> "The useFocusEffect is analogous to React's useEffect hook. The only difference is that it only runs if the screen is currently focused."

Moi aussi je ne comprend pas trop j'avais laissé le useEffect de base et ensuite j'ai vu que les deux useEffect et useFocusEffect était render quand je changeais de tab, j'ai retiré, j'ai bien log, et j'ai testé et ça fonctionne

sonarcloud · 2024-09-20T15:56:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-09-20T16:03:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

YassinL added 5 commits September 20, 2024 15:14

(PC-31778) feat(api): update api file

9f6ddb9

(PC-31778) feat(TabLayout): adapt tabLayout on change

182450b

(PC-31778) feat(EndedBookings): adapt types with new post reaction

e694869

(PC-31778) feat(Bookings): post reaction on tab change or on change s…

c39ad07

…creen

(PC-31778) fix(EndedBookings): fix test

e4d0cb4

YassinL force-pushed the PC-31778 branch from 2a79f02 to e4d0cb4 Compare September 20, 2024 13:32

(PC-31778) fix types

a83096b

mmeissonnier-pass reviewed Sep 20, 2024

View reviewed changes

mmeissonnier-pass approved these changes Sep 20, 2024

View reviewed changes

YassinL force-pushed the PC-31778 branch from 264de80 to d4062f0 Compare September 20, 2024 15:35

(PC-31778) refacto wording after review

f082255

YassinL force-pushed the PC-31778 branch from d4062f0 to f082255 Compare September 20, 2024 15:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(PC-31778) feat(Bookings): post reaction on tab change or on change screen #6909

(PC-31778) feat(Bookings): post reaction on tab change or on change screen #6909

YassinL commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024 •

edited

Loading

mmeissonnier-pass Sep 20, 2024 •

edited

Loading

YassinL Sep 20, 2024

sonarcloud bot commented Sep 20, 2024

sonarcloud bot commented Sep 20, 2024

(PC-31778) feat(Bookings): post reaction on tab change or on change screen #6909

Are you sure you want to change the base?

(PC-31778) feat(Bookings): post reaction on tab change or on change screen #6909

Conversation

YassinL commented Sep 20, 2024 • edited Loading

Flakiness

Checklist

Screenshots

github-actions bot commented Sep 20, 2024 • edited Loading

Performance Comparison Report

Significant Changes To Render Duration

Meaningless Changes To Render Duration

Changes To Render Count

Added Scenarios

Removed Scenarios

mmeissonnier-pass Sep 20, 2024 • edited Loading

Choose a reason for hiding this comment

YassinL Sep 20, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Sep 20, 2024

Quality Gate passed

sonarcloud bot commented Sep 20, 2024

Quality Gate passed

YassinL commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024 •

edited

Loading

mmeissonnier-pass Sep 20, 2024 •

edited

Loading