Linting #1
Linting #1
Conversation
|
I need to get on the ball and add Typescript definitions now :) |
|
Cool :) I am trying to finish up a Promise PR if that may affect your plans... And if we're pulling off the Band-Aid with a new Promises API anyways, I would also like to propose a new API so that function signatures or return objects like |
|
I’m happy to wait for Promises. I think optional paeans should be grouped into an object too. |
|
I'll check this once passport-next/passport#19 is merged. |
brettz9
force-pushed
the
linting
branch
5 times, most recently
from
8171ace to
c398d71
Compare
brettz9
force-pushed
the
linting
branch
3 times, most recently
from
2aa4020 to
8f14b99
Compare
|
I've updated the devDeps and linted/tested against these updates... As the single dependency of passport, I'd think this would be good to update to a new major version first so the next passport update could depend on it. |
|
But note that even with this PR, passport-strategy still has make files (as does passport-local)... |
- Refactoring: Use ES6 classes - Travis: Add Node 11 and 12 - Linting: Add eslint-config-ash-nazg (and remove jshint) to JS, Markdown, HTML - Maintenance: Add `.editorconfig` - npm: Add `package-lock.json` - npm: Add recommended fields (contributors, homepage) - npm: Change deprecated `licenses` with `license` - npm: Add `lint` and `lintfix` scripts - npm: Update link from http to https - npm: Update chai, mocha
- npm: Simplify test (full relative binary path not needed in npm scripts) - npm: Update devDeps.
- npm: Bump engines and browserslist to Node 10
- npm: Add separate `mocha` (no-coverage) test script and add coverage to `test`
…Dep. and drop need for typescript)
brettz9
force-pushed
the
linting
branch
2 times, most recently
from
cd0bdfd to
00d1f14
Compare
…plugin-markdown` and `eslint-plugin-jsdoc` - npm: Update devDeps.
- npm: Update devDeps. - Testing: Avoid need for own bootstrap file
- Testing Check Node 16
4 participants
eslint-config-ash-nazgand apply (and remove jshint) to JS, Markdown, HTML.editorconfigmocha(no-coverage) test script and add coverage totestpackage-lock.jsonlicenseswithlicenselintandlintfixscriptsAdd changes similar to those proposed for passport (its depender)