Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-613: replace initImage with initContainer #1117

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Apr 3, 2025

K8SPG-613 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPG-613

DESCRIPTION

This PR replaces .spec.initImage and .spec.backups.pgbackrest.initImage with .spec.initContainer and .spec.backups.pgbackrest.initContainer.
These fields have the following spec:

initContainer:
  image: perconalab/percona-postgresql-operator:main
  resources:
    limits:
      cpu: 2.0
      memory: 4Gi
  containerSecurityContext:
    fsGroup: 1001
    runAsUser: 1001
    runAsNonRoot: true
    fsGroupChangePolicy: "OnRootMismatch"
    runAsGroup: 1001
    seLinuxOptions:
      type: spc_t
      level: s0:c123,c456
    seccompProfile:
      type: Localhost
      localhostProfile: localhost/profile.json
    supplementalGroups:
    - 1001
    sysctls:
    - name: net.ipv4.tcp_keepalive_time
      value: "600"
    - name: net.ipv4.tcp_keepalive_intvl
      value: "60"

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

gkech
gkech previously approved these changes Apr 3, 2025
@gkech
Copy link
Contributor

gkech commented Apr 3, 2025

we have some assertion issues on the upgrade-consistency test

@gkech
Copy link
Contributor

gkech commented Apr 3, 2025

we need to also check the unit tests, TestGenerateBackupJobIntent

@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
monitoring passed
monitoring-pmm3 passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
sidecars passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 20 out of 20

commit: ca136b8
image: perconalab/percona-postgresql-operator:PR-1117-ca136b8a9

@@ -11,4 +11,5 @@ commands:
get_cr \
| yq eval '
.spec.crVersion="2.5.0"' - \
| yq eval ".spec.backups.pgbackrest.image=\"${IMAGE_BASE}:main-ppg$PG_VER-pgbackrest\"" - \
| kubectl -n "${NAMESPACE}" apply -f -
Copy link
Contributor

@nmarukovich nmarukovich Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hors should we use updated image name?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmarukovich only from PGO 2.7.0

@hors hors added this to the 2.7.0 milestone Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants