fix: Enable gocognit linter rule
#4879
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the gocognit linter by removing it from the disabled list in .golangci.yml and adds //nolint:gocognit directives to functions that trigger warnings. Also removes an unused //nolint:gocognit directive that was revealed by enabling the linter. Signed-off-by: majiayu000 <[email protected]>
majiayu000
requested review from
idoqo and
maxkondr
and removed request for
a team
Contributor
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v3 #4879 +/- ##
=======================================
Coverage 45.93% 45.93%
=======================================
Files 364 364
Lines 37880 37880
=======================================
Hits 17399 17399
- Misses 18805 18806 +1
+ Partials 1676 1675 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ademidoff
approved these changes
Jan 4, 2026
Author
|
I've fixed the CI failure by removing |
maxkondr
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #2343
Changes
gocognitfrom the disabled linters list in.golangci.ymlto enable the linter//nolint:gocognitdirectives to 36 functions that trigger gocognit warnings, as these functions have high cognitive complexity that is inherent to their functionality//nolint:gocognitdirective inmanaged/services/telemetry/config.gothat was revealed when the linter was enabledThe approach of using
//nolint:gocognitdirectives rather than refactoring the functions is appropriate here because:gocognitlinter is already excluded for test files (in.golangci.ymlexclusions)Test plan
golangci-lint run --enable-only gocognitreturns 0 issues//nolint:gocognitdirectives remain