fix: Enable gocognit linter rule

.golangci.yml

@@ -4,14 +4,13 @@ linters:
   disable:
     - copyloopvar         # replaced exportloopref, but we don't need it for Go 1.22+
     - dupl                # we can't avoid duplicating code
-    - embeddedstructfieldcheck # need it for autogenerated code
+
     - err113              # extra work & poor benefit (renamed from goerr113)
     - exhaustruct         # too many files to fix/nolint
-    - funcorder           # not very useful
+
     - funlen              # useless
     - gochecknoglobals    # mostly useless
     - gochecknoinits      # we use init functions
-    - gocognit
     - gocyclo             # using cyclop with the max 30 instead
     - godox               # we sometimes leave TODOS right in the code
     - gomoddirectives     # we use replace directives

agent/agents/mysql/perfschema/perfschema.go

@@ -305,7 +305,7 @@ func (m *PerfSchema) refreshHistoryCache(ctx context.Context) error {
 	return nil
 }
 
-func (m *PerfSchema) getNewBuckets(periodStart time.Time, periodLengthSecs uint32) ([]*agentv1.MetricsBucket, error) {
+func (m *PerfSchema) getNewBuckets(periodStart time.Time, periodLengthSecs uint32) ([]*agentv1.MetricsBucket, error) { //nolint:gocognit
 	current, err := getSummaries(m.q)
 	if err != nil {
 		return nil, err

agent/agents/mysql/slowlog/slowlog.go

@@ -408,7 +408,7 @@ func hashIntoQueryID(fingerprint string) string {
 
 // makeBuckets is a pure function for easier testing.
 //
-//nolint:cyclop,maintidx
+//nolint:gocognit,cyclop,maintidx
 func makeBuckets(
 	agentID string,
 	res event.Result,

agent/agents/postgres/pgstatmonitor/pgstatmonitor.go

@@ -534,7 +534,7 @@ func (m *PGStatMonitorQAN) getNewBuckets(ctx context.Context, periodLengthSecs u
 
 // makeBuckets uses current state of pg_stat_monitor table and accumulated previous state
 // to make metrics buckets.
-func (m *PGStatMonitorQAN) makeBuckets(current, cache map[time.Time]map[string]*pgStatMonitorExtended) []*agentv1.MetricsBucket {
+func (m *PGStatMonitorQAN) makeBuckets(current, cache map[time.Time]map[string]*pgStatMonitorExtended) []*agentv1.MetricsBucket { //nolint:gocognit
 	res := make([]*agentv1.MetricsBucket, 0, len(current))
 
 	for bucketStartTime, bucket := range current {

agent/agents/postgres/pgstatmonitor/stat_monitor_cache.go

@@ -62,6 +62,8 @@ func newStatMonitorCache(l *logrus.Entry) *statMonitorCache {
 
 // getStatMonitorExtended returns the current state of pg_stat_monitor table with extended information (database, username)
 // and the previous cashed state grouped by bucket start time.
+//
+//nolint:gocognit
 func (ssc *statMonitorCache) getStatMonitorExtended(
 	ctx context.Context,
 	q *reform.Querier,

agent/client/client.go

@@ -301,7 +301,7 @@ func (c *Client) processJobsResults(ctx context.Context) {
 	}
 }
 
-func (c *Client) processSupervisorRequests(ctx context.Context) {
+func (c *Client) processSupervisorRequests(ctx context.Context) { //nolint:gocognit
 	var wg sync.WaitGroup
 
 	wg.Add(1)

agent/cmd/pmm-agent-entrypoint/main.go

@@ -127,7 +127,7 @@ func sendSIGKILLwithTimeout(process *os.Process, timeout int, l *logrus.Entry) *
 	})
 }
 
-func main() {
+func main() { //nolint:gocognit
 	config := reaper.MakeConfig()
 	config.Debug = false
 	reaper.RunForked(config)

agent/config/config.go

@@ -192,7 +192,7 @@ func getFromCmdLine(cfg *Config, l *logrus.Entry) (string, error) {
 }
 
 // get is Get for unit tests: it parses args instead of command-line.
-func get(args []string, cfg *Config, l *logrus.Entry) (string, error) { //nolint:cyclop
+func get(args []string, cfg *Config, l *logrus.Entry) (string, error) { //nolint:gocognit,cyclop
 	var configFileF string
 	var err error
 	// tweak configuration on exit to cover all return points

managed/cmd/pmm-managed/main.go

@@ -623,7 +623,7 @@ func newClickhouseDB(dsn string, maxIdleConns, maxOpenConns int) (*sql.DB, error
 	return db, nil
 }
 
-func main() { //nolint:maintidx,cyclop
+func main() { //nolint:gocognit,maintidx,cyclop
 	// empty version breaks much of pmm-managed logic
 	if version.Version == "" {
 		panic("pmm-managed version is not set during build.")

managed/models/agent_model.go

@@ -487,7 +487,7 @@ type DSNParams struct {
 }
 
 // DSN returns a DSN string for accessing a given Service with this Agent (and an implicit driver).
-func (s *Agent) DSN(service *Service, dsnParams DSNParams, tdp *DelimiterPair, pmmAgentVersion *version.Parsed) string { //nolint:cyclop,maintidx
+func (s *Agent) DSN(service *Service, dsnParams DSNParams, tdp *DelimiterPair, pmmAgentVersion *version.Parsed) string { //nolint:gocognit,cyclop,maintidx
 	host := pointer.GetString(service.Address)
 	port := pointer.GetUint16(service.Port)
 	socket := pointer.GetString(service.Socket)
@@ -835,7 +835,7 @@ func (s *Agent) IsMySQLTablestatsGroupEnabled() bool {
 }
 
 // Files returns files map required to connect to DB.
-func (s Agent) Files() map[string]string {
+func (s Agent) Files() map[string]string { //nolint:gocognit
 	switch s.AgentType {
 	case MySQLdExporterType, QANMySQLPerfSchemaAgentType, QANMySQLSlowlogAgentType:
 		files := make(map[string]string)

managed/models/encryption_helpers.go

@@ -34,7 +34,7 @@ func DecryptAgent(agent Agent) Agent {
 	return agentEncryption(agent, encryption.Decrypt)
 }
 
-func agentEncryption(agent Agent, handler func(string) (string, error)) Agent {
+func agentEncryption(agent Agent, handler func(string) (string, error)) Agent { //nolint:gocognit
 	if agent.Username != nil {
 		username, err := handler(*agent.Username)
 		if err != nil {

managed/models/node_helpers.go

@@ -247,7 +247,7 @@ func CreateNode(q *reform.Querier, nodeType NodeType, params *CreateNodeParams)
 }
 
 // RemoveNode removes single Node.
-func RemoveNode(q *reform.Querier, id string, mode RemoveMode) error {
+func RemoveNode(q *reform.Querier, id string, mode RemoveMode) error { //nolint:gocognit
 	n, err := FindNodeByID(q, id)
 	if err != nil {
 		return err

managed/models/service_helpers.go

@@ -314,7 +314,7 @@ func AddNewService(q *reform.Querier, serviceType ServiceType, params *AddDBMSSe
 
 // RemoveService removes single Service.
 // If associated service software versions entry exists it is removed by the ON DELETE CASCADE option.
-func RemoveService(q *reform.Querier, id string, mode RemoveMode) error {
+func RemoveService(q *reform.Querier, id string, mode RemoveMode) error { //nolint:gocognit
 	s, err := FindServiceByID(q, id)
 	if err != nil {
 		return err

managed/models/settings_helpers.go

@@ -119,7 +119,7 @@ func SetPMMServerID(q reform.DBTX) error {
 }
 
 // UpdateSettings updates only non-zero, non-empty values.
-func UpdateSettings(q reform.DBTX, params *ChangeSettingsParams) (*Settings, error) { //nolint:cyclop
+func UpdateSettings(q reform.DBTX, params *ChangeSettingsParams) (*Settings, error) { //nolint:gocognit,cyclop
 	err := ValidateSettings(params)
 	if err != nil {
 		return nil, NewInvalidArgumentError("%s", err.Error())

managed/services/agents/handler.go

@@ -63,7 +63,7 @@ func NewHandler(db *reform.DB, qanClient qanClient, vmdb prometheusService, regi
 }
 
 // Run takes over pmm-agent gRPC stream and runs it until completion.
-func (h *Handler) Run(stream agentv1.AgentService_ConnectServer) error {
+func (h *Handler) Run(stream agentv1.AgentService_ConnectServer) error { //nolint:gocognit
 	disconnectReason := "unknown"
 
 	ctx := stream.Context()

managed/services/agents/jobs.go

@@ -67,7 +67,7 @@ func NewJobsService(db *reform.DB, registry *Registry, retention retentionServic
 }
 
 // RestartJob restarts a job with the given jobID.
-func (s *JobsService) RestartJob(ctx context.Context, jobID string) error {
+func (s *JobsService) RestartJob(ctx context.Context, jobID string) error { //nolint:gocognit
 	var job *models.Job
 	var artifact *models.Artifact
 	var locationModel *models.BackupLocation
@@ -169,7 +169,7 @@ func (s *JobsService) RestartJob(ctx context.Context, jobID string) error {
 	return nil
 }
 
-func (s *JobsService) handleJobResult(_ context.Context, l *logrus.Entry, result *agentv1.JobResult) { //nolint:cyclop
+func (s *JobsService) handleJobResult(_ context.Context, l *logrus.Entry, result *agentv1.JobResult) { //nolint:gocognit,cyclop
 	var scheduleID string
 	if errTx := s.db.InTransaction(func(t *reform.TX) error { //nolint:contextcheck
 		job, err := models.FindJobByID(t.Querier, result.JobId)

managed/services/agents/state.go

@@ -140,7 +140,7 @@ func (u *StateUpdater) runStateChangeHandler(ctx context.Context, agent *pmmAgen
 }
 
 // sendSetStateRequest sends SetStateRequest to given pmm-agent.
-func (u *StateUpdater) sendSetStateRequest(ctx context.Context, agent *pmmAgentInfo) error { //nolint:cyclop,maintidx
+func (u *StateUpdater) sendSetStateRequest(ctx context.Context, agent *pmmAgentInfo) error { //nolint:gocognit,cyclop,maintidx
 	l := logger.Get(ctx)
 	start := time.Now()
 	defer func() {

managed/services/backup/backup_service.go

@@ -69,7 +69,7 @@ type PerformBackupParams struct {
 }
 
 // PerformBackup starts on-demand backup.
-func (s *Service) PerformBackup(ctx context.Context, params PerformBackupParams) (string, error) { //nolint:cyclop
+func (s *Service) PerformBackup(ctx context.Context, params PerformBackupParams) (string, error) { //nolint:gocognit,cyclop
 	dbVersion, err := s.compatibilityService.CheckSoftwareCompatibilityForService(ctx, params.ServiceID)
 	if err != nil {
 		return "", err

managed/services/backup/pitr_timerange_service.go

@@ -270,7 +270,7 @@ func getTimelines(slices []*oplogChunk) []Timeline {
 
 // mergeTimelines merges overlapping sets on timelines
 // it presumes timelines are sorted and don't start from 0.
-func mergeTimelines(timelines ...[]Timeline) []Timeline {
+func mergeTimelines(timelines ...[]Timeline) []Timeline { //nolint:gocognit
 	// fast paths
 	if len(timelines) == 0 {
 		return nil

managed/services/inventory/services.go

@@ -299,7 +299,7 @@ func (ss *ServicesService) AddExternalService(ctx context.Context, params *model
 // Remove removes Service without any Agents.
 // Removes Service with the Agents if force == true.
 // Returns an error if force == false and Service has Agents.
-func (ss *ServicesService) Remove(ctx context.Context, id string, force bool) error {
+func (ss *ServicesService) Remove(ctx context.Context, id string, force bool) error { //nolint:gocognit
 	pmmAgentIDs := make(map[string]struct{})
 
 	if e := ss.db.InTransactionContext(ctx, nil, func(tx *reform.TX) error {

managed/services/management/azure_database.go

@@ -189,7 +189,7 @@ func (s *ManagementService) DiscoverAzureDatabase(
 }
 
 // AddAzureDatabase add azure database to monitoring.
-func (s *ManagementService) AddAzureDatabase(ctx context.Context, req *managementv1.AddAzureDatabaseRequest) (*managementv1.AddAzureDatabaseResponse, error) {
+func (s *ManagementService) AddAzureDatabase(ctx context.Context, req *managementv1.AddAzureDatabaseRequest) (*managementv1.AddAzureDatabaseResponse, error) { //nolint:gocognit
 	if !s.isAzureEnabled() {
 		return nil, services.ErrAzureDisabled
 	}

managed/services/management/external.go

@@ -29,7 +29,7 @@ import (
 )
 
 // AddExternal adds an external service based on the provided request.
-func (s *ManagementService) addExternal(ctx context.Context, req *managementv1.AddExternalServiceParams) (*managementv1.AddServiceResponse, error) {
+func (s *ManagementService) addExternal(ctx context.Context, req *managementv1.AddExternalServiceParams) (*managementv1.AddServiceResponse, error) { //nolint:gocognit
 	external := &managementv1.ExternalServiceResult{}
 	var pmmAgentID *string
 

managed/services/management/haproxy.go

@@ -29,7 +29,7 @@ import (
 )
 
 // AddHAProxy adds an HAProxy service based on the provided request.
-func (s *ManagementService) addHAProxy(ctx context.Context, req *managementv1.AddHAProxyServiceParams) (*managementv1.AddServiceResponse, error) {
+func (s *ManagementService) addHAProxy(ctx context.Context, req *managementv1.AddHAProxyServiceParams) (*managementv1.AddServiceResponse, error) { //nolint:gocognit
 	var pmmAgentID *string
 	haproxy := &managementv1.HAProxyServiceResult{}
 

managed/services/management/mongodb.go

@@ -28,7 +28,7 @@ import (
 )
 
 // AddMongoDB adds "MongoDB Service", "MongoDB Exporter Agent" and "QAN MongoDB Profiler".
-func (s *ManagementService) addMongoDB(ctx context.Context, req *managementv1.AddMongoDBServiceParams) (*managementv1.AddServiceResponse, error) {
+func (s *ManagementService) addMongoDB(ctx context.Context, req *managementv1.AddMongoDBServiceParams) (*managementv1.AddServiceResponse, error) { //nolint:gocognit
 	mongodb := &managementv1.MongoDBServiceResult{}
 
 	if e := s.db.InTransactionContext(ctx, nil, func(tx *reform.TX) error {

managed/services/management/mysql.go

@@ -33,7 +33,7 @@ const (
 )
 
 // AddMySQL adds "MySQL Service", "MySQL Exporter Agent" and "QAN MySQL PerfSchema Agent".
-func (s *ManagementService) addMySQL(ctx context.Context, req *managementv1.AddMySQLServiceParams) (*managementv1.AddServiceResponse, error) {
+func (s *ManagementService) addMySQL(ctx context.Context, req *managementv1.AddMySQLServiceParams) (*managementv1.AddServiceResponse, error) { //nolint:gocognit
 	mysql := &managementv1.MySQLServiceResult{}
 
 	errTx := s.db.InTransactionContext(ctx, nil, func(tx *reform.TX) error {

managed/services/management/node.go

@@ -36,7 +36,7 @@ import (
 )
 
 // RegisterNode performs the registration of a new node.
-func (s *ManagementService) RegisterNode(ctx context.Context, req *managementv1.RegisterNodeRequest) (*managementv1.RegisterNodeResponse, error) {
+func (s *ManagementService) RegisterNode(ctx context.Context, req *managementv1.RegisterNodeRequest) (*managementv1.RegisterNodeResponse, error) { //nolint:gocognit
 	res := &managementv1.RegisterNodeResponse{}
 
 	e := s.db.InTransactionContext(ctx, nil, func(tx *reform.TX) error {
@@ -213,7 +213,7 @@ func (s *ManagementService) UnregisterNode(ctx context.Context, req *managementv
 const upQuery = `up{job=~".*_hr$"}`
 
 // ListNodes returns a filtered list of Nodes.
-func (s *ManagementService) ListNodes(ctx context.Context, req *managementv1.ListNodesRequest) (*managementv1.ListNodesResponse, error) {
+func (s *ManagementService) ListNodes(ctx context.Context, req *managementv1.ListNodesRequest) (*managementv1.ListNodesResponse, error) { //nolint:gocognit
 	filters := models.NodeFilters{
 		NodeType: services.ProtoToModelNodeType(req.NodeType),
 	}

managed/services/management/postgresql.go

@@ -28,7 +28,7 @@ import (
 )
 
 // AddPostgreSQL adds "PostgreSQL Service", "PostgreSQL Exporter Agent" and "QAN PostgreSQL PerfSchema Agent".
-func (s *ManagementService) addPostgreSQL(ctx context.Context, req *managementv1.AddPostgreSQLServiceParams) (*managementv1.AddServiceResponse, error) {
+func (s *ManagementService) addPostgreSQL(ctx context.Context, req *managementv1.AddPostgreSQLServiceParams) (*managementv1.AddServiceResponse, error) { //nolint:gocognit
 	postgres := &managementv1.PostgreSQLServiceResult{}
 
 	errTx := s.db.InTransactionContext(ctx, nil, func(tx *reform.TX) error {

managed/services/management/rds.go

@@ -140,7 +140,7 @@ func listRegions(partitions []string) []string {
 }
 
 // DiscoverRDS discovers RDS instances.
-func (s *ManagementService) DiscoverRDS(ctx context.Context, req *managementv1.DiscoverRDSRequest) (*managementv1.DiscoverRDSResponse, error) {
+func (s *ManagementService) DiscoverRDS(ctx context.Context, req *managementv1.DiscoverRDSRequest) (*managementv1.DiscoverRDSResponse, error) { //nolint:gocognit
 	l := logger.Get(ctx).WithField("component", "discover/rds")
 
 	settings, err := models.GetSettings(s.db.Querier)
@@ -258,7 +258,7 @@ func (s *ManagementService) DiscoverRDS(ctx context.Context, req *managementv1.D
 }
 
 // AddRDS adds RDS instance.
-func (s *ManagementService) addRDS(ctx context.Context, req *managementv1.AddRDSServiceParams) (*managementv1.AddServiceResponse, error) { //nolint:cyclop,maintidx
+func (s *ManagementService) addRDS(ctx context.Context, req *managementv1.AddRDSServiceParams) (*managementv1.AddServiceResponse, error) { //nolint:gocognit,cyclop,maintidx
 	rds := &managementv1.RDSServiceResult{}
 
 	pmmAgentID := models.PMMServerAgentID

managed/services/management/service.go

@@ -119,7 +119,7 @@ func (s *ManagementService) AddService(ctx context.Context, req *managementv1.Ad
 }
 
 // ListServices returns a filtered list of Services with some attributes from Agents and Nodes.
-func (s *ManagementService) ListServices(ctx context.Context, req *managementv1.ListServicesRequest) (*managementv1.ListServicesResponse, error) {
+func (s *ManagementService) ListServices(ctx context.Context, req *managementv1.ListServicesRequest) (*managementv1.ListServicesResponse, error) { //nolint:gocognit
 	filters := models.ServiceFilters{
 		NodeID:        req.NodeId,
 		ServiceType:   services.ProtoToModelServiceType(req.ServiceType),
@@ -257,7 +257,7 @@ func (s *ManagementService) ListServices(ctx context.Context, req *managementv1.
 }
 
 // RemoveService removes a Service along with its Agents.
-func (s *ManagementService) RemoveService(ctx context.Context, req *managementv1.RemoveServiceRequest) (*managementv1.RemoveServiceResponse, error) {
+func (s *ManagementService) RemoveService(ctx context.Context, req *managementv1.RemoveServiceRequest) (*managementv1.RemoveServiceResponse, error) { //nolint:gocognit
 	err := s.validateRequest(req)
 	if err != nil {
 		return nil, err

managed/services/preconditions.go

@@ -95,7 +95,7 @@ func CheckMongoDBBackupPreconditions(q *reform.Querier, mode models.BackupMode,
 // in the same folder may cause data inconsistency.
 //
 // WARNING: This function is valid only when executed as part of transaction with serializable isolation level.
-func CheckArtifactOverlapping(q *reform.Querier, serviceID, locationID, folder string) error {
+func CheckArtifactOverlapping(q *reform.Querier, serviceID, locationID, folder string) error { //nolint:gocognit
 	// TODO This doesn't work for all cases. For example, there may exist more than one storage locations pointing to the same place.
 
 	const (

managed/services/qan/client.go

@@ -169,7 +169,7 @@ func (c *Client) SchemaByQueryID(ctx context.Context, serviceID, queryID string)
 }
 
 // Collect adds labels to the data from pmm-agent and sends it to qan-api.
-func (c *Client) Collect(ctx context.Context, metricsBuckets []*agentv1.MetricsBucket) error {
+func (c *Client) Collect(ctx context.Context, metricsBuckets []*agentv1.MetricsBucket) error { //nolint:gocognit
 	start := time.Now()
 	defer func() {
 		if dur := time.Since(start); dur > time.Second {

managed/services/server/server.go

@@ -621,7 +621,7 @@ func (s *Server) validateChangeSettingsRequest(ctx context.Context, req *serverv
 }
 
 // ChangeSettings changes PMM Server settings.
-func (s *Server) ChangeSettings(ctx context.Context, req *serverv1.ChangeSettingsRequest) (*serverv1.ChangeSettingsResponse, error) {
+func (s *Server) ChangeSettings(ctx context.Context, req *serverv1.ChangeSettingsRequest) (*serverv1.ChangeSettingsResponse, error) { //nolint:gocognit
 	s.envRW.RLock()
 	defer s.envRW.RUnlock()
 	if err := s.validateChangeSettingsRequest(ctx, req); err != nil {

managed/services/supervisord/supervisord.go

@@ -102,7 +102,7 @@ func New(configDir string, params *models.Params) *Service {
 }
 
 // Run reads supervisord's log (maintail) and sends events to subscribers.
-func (s *Service) Run(ctx context.Context) {
+func (s *Service) Run(ctx context.Context) { //nolint:gocognit
 	if s.supervisorctlPath == "" {
 		s.l.Errorf("supervisorctl not found, updates are disabled.")
 		return

managed/services/telemetry/config.go

@@ -178,7 +178,7 @@ const (
 )
 
 // Init initializes telemetry config.
-func (c *ServiceConfig) Init(l *logrus.Entry) error { //nolint:gocognit
+func (c *ServiceConfig) Init(l *logrus.Entry) error {
 	c.l = l
 
 	configFile := os.Getenv(envConfigFile)

managed/services/telemetry/telemetry.go

@@ -210,7 +210,7 @@ func (s *Service) processSendCh(ctx context.Context) {
 	}
 }
 
-func (s *Service) prepareReport(ctx context.Context) *telemetryv1.GenericReport {
+func (s *Service) prepareReport(ctx context.Context) *telemetryv1.GenericReport { //nolint:gocognit
 	initializedDataSources := make(map[DataSourceName]DataSource)
 	telemetryMetric, _ := s.makeMetric(ctx)
 	var totalTime time.Duration

managed/services/victoriametrics/prometheus.go

@@ -28,7 +28,7 @@ import (
 
 // AddScrapeConfigs - adds agents scrape configuration to given scrape config,
 // pmm_agent_id and push_metrics used for filtering.
-func AddScrapeConfigs(l *logrus.Entry, cfg *config.Config, q *reform.Querier, //nolint:cyclop,maintidx
+func AddScrapeConfigs(l *logrus.Entry, cfg *config.Config, q *reform.Querier, //nolint:gocognit,cyclop,maintidx
 	globalResolutions *models.MetricsResolutions, pmmAgentID *string, pushMetrics bool, skipExternalAgents bool,
 ) error {
 	agents, err := models.FindAgentsForScrapeConfig(q, pmmAgentID, pushMetrics)

managed/utils/envvars/parser.go

@@ -70,7 +70,7 @@ func (e InvalidDurationError) Error() string { return string(e) }
 //   - the environment variables prefixed with GF_ passed as related to Grafana.
 //   - the environment variables relating to proxies
 //   - the environment variable set by podman
-func ParseEnvVars(envs []string) (*models.ChangeSettingsParams, []error, []string) { //nolint:cyclop,maintidx
+func ParseEnvVars(envs []string) (*models.ChangeSettingsParams, []error, []string) { //nolint:gocognit,cyclop,maintidx
 	envSettings := &models.ChangeSettingsParams{}
 	var errs []error
 	var warns []string