fix show_excluded_items in @navigation api #1816
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
In Plone 5.2 test is broken with and without the fix. |
|
@jenkins-plone-org please run jobs |
stevepiercy
requested changes
Sep 19, 2024
| @@ -124,6 +124,35 @@ def test_dont_broke_with_contents_without_review_state(self): | |||
| ) | |||
| self.assertIsNone(response.json()["items"][1]["items"][3]["review_state"]) | |||
|
|
|||
| def test_show_exclude_items(self): | |||
There was a problem hiding this comment.
Typo.
Suggested change
| def test_show_exclude_items(self): | |
| def test_show_excluded_items(self): |
| @@ -0,0 +1,2 @@ | |||
| Fix incorrect condition for show_ecluded_items setting in the @navigation API. | |||
There was a problem hiding this comment.
Add reST syntax and fix typo.
Suggested change
| Fix incorrect condition for show_ecluded_items setting in the @navigation API. | |
| Fix incorrect condition for ``show_excluded_items`` setting in the ``@navigation`` API. |
| response = self.api_session.get( | ||
| "/folder/@navigation", params={"expand.navigation.depth": 2} | ||
| ) | ||
| self.assertNotIn( |
There was a problem hiding this comment.
Is settings.show_excluded_items==True at this point? That could explain the test failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
show_ecluded_itemssetting does not work for the@navigationAPI due to an incorrect condition.📚 Documentation preview 📚: https://plonerestapi--1816.org.readthedocs.build/