fix show_excluded_items in @navigation api

news/1816.bugfix

@@ -0,0 +1,2 @@
+Fix incorrect condition for show_ecluded_items setting in the @navigation API.
+[mamico]

src/plone/restapi/services/navigation/get.py

@@ -135,7 +135,9 @@ def navtree(self):
             if brain_parent_path == navtree_path:
                 # This should be already provided by the portal_tabs_view
                 continue
-            if brain.exclude_from_nav and not context_path.startswith(brain_path):
+            if brain.exclude_from_nav and not f"{brain_path}/".startswith(
+                f"{context_path}/"
+            ):
                 # skip excluded items if they're not in our context path
                 continue
             url = brain.getURL()

src/plone/restapi/tests/test_services_navigation.py

@@ -124,6 +124,35 @@ def test_dont_broke_with_contents_without_review_state(self):
         )
         self.assertIsNone(response.json()["items"][1]["items"][3]["review_state"])
 
+    def test_show_exclude_items(self):
+        createContentInContainer(
+            self.folder,
+            "Folder",
+            id="excluded-subfolder",
+            title="Excluded SubFolder",
+            exclude_from_nav=True,
+        )
+        transaction.commit()
+        response = self.api_session.get(
+            "/folder/@navigation", params={"expand.navigation.depth": 2}
+        )
+        self.assertNotIn(
+            "Excluded SubFolder",
+            [item["title"] for item in response.json()["items"][1]["items"]],
+        )
+
+        registry = getUtility(IRegistry)
+        settings = registry.forInterface(INavigationSchema, prefix="plone")
+        settings.show_excluded_items = True
+        transaction.commit()
+        response = self.api_session.get(
+            "/folder/@navigation", params={"expand.navigation.depth": 2}
+        )
+        self.assertIn(
+            "Excluded SubFolder",
+            [item["title"] for item in response.json()["items"][1]["items"]],
+        )
+
     def test_navigation_sorting(self):
         registry = getUtility(IRegistry)
         registry["plone.displayed_types"] = (