Sparteo: Add required query params to adapter endpoint #4556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-sormonte
force-pushed
the
Sparteo--add-required-query-params-to-adapter-endpoint
branch
from
f9e0dd1 to
ce7066f
Compare
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
t-sormonte
force-pushed
the
Sparteo--add-required-query-params-to-adapter-endpoint
branch
from
ce7066f to
81ad9b9
Compare
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
bsardo
changed the title
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
t-sormonte
force-pushed
the
Sparteo--add-required-query-params-to-adapter-endpoint
branch
from
c11cc87 to
3b4f311
Compare
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
t-sormonte
force-pushed
the
Sparteo--add-required-query-params-to-adapter-endpoint
branch
from
465128b to
8fc2270
Compare
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
t-sormonte
force-pushed
the
Sparteo--add-required-query-params-to-adapter-endpoint
branch
from
4993d1e to
ff8b127
Compare
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
t-sormonte
force-pushed
the
Sparteo--add-required-query-params-to-adapter-endpoint
branch
from
ff8b127 to
cc709f3
Compare
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
ccorbo
reviewed
Oct 30, 2025
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
11 tasks
ccorbo
reviewed
Nov 3, 2025
static/bidder-info/sparteo.yaml
Outdated
| - video | ||
| - native | ||
| endpoint: "https://bid.sparteo.com/s2s-auction" | ||
| endpoint: "https://bid.sparteo.com/s2s-auction?network_id={{.NetworkId}}&{{if .SiteDomain}}&site_domain={{.SiteDomain}}{{end}}{{if .AppDomain}}&app_domain={{.AppDomain}}{{end}}{{if .Bundle}}&bundle={{.Bundle}}{{end}}" |
Contributor
There was a problem hiding this comment.
won't this result in an extra '&' after network id, also could you just pass the params if they're present or not and they will come thorugh as empty params instead of using the condtionals?
Contributor
Author
There was a problem hiding this comment.
Indeed, i have removed the extra &.
Concerning the params we really prefers to do not have the query param instead of an empty one. But i'm open to do not use conditional templating. The java adapter just append the query param if present. Would this be more acceptable ?
Contributor
There was a problem hiding this comment.
@bsardo whats the guidance around conditional templating in the endpoint?
Contributor
There was a problem hiding this comment.
Talked to @bsardo - can you please handle conditionally building the endpoint URL in the adapter itself
Contributor
Author
There was a problem hiding this comment.
I wasn't sure if i had to stick with replacement macro building the conditional template dynamically or i could just use query param to mirror my Prebid Java adapter logic.
I chose to mirror my java logic but if i have misunderstood, please let me know, i'll adjust the code.
Contributor
There was a problem hiding this comment.
yeah you want to use the endpoint template to build your endpoint url with macros
Example here: https://github.com/prebid/prebid-server/blob/master/adapters/adview/adview.go#L163
t-sormonte
force-pushed
the
Sparteo--add-required-query-params-to-adapter-endpoint
branch
from
30a22ca to
383691e
Compare
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
Collaborator
|
@t-sormonte can you try merging with master please? For some reason it is saying you have conflicts that must be resolved but it is not showing what they are. |
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
Contributor
Author
|
Hi @bsardo , @ccorbo and @pm-isha-bharti , When you have a moment, could we please continue the review on the Go version so it can stay aligned with the other implementations? |
ccorbo
reviewed
Nov 19, 2025
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
Contributor
Author
|
Hey @ccorbo , |
Contributor
Author
|
hi @ccorbo , Thank you in advance for your time. |
ccorbo
reviewed
Dec 4, 2025
Code coverage summaryNote:
sparteoRefer here for heat map coverage report |
ccorbo
approved these changes
Dec 5, 2025
Contributor
Author
|
Thanks @ccorbo for the review, time spent and approval. Hi @pm-isha-bharti, Theses changes are urgently expected as it already has been released in Prebid.js 10.17.0 and 9.53.4 and in Prebid Server Java 3.36.0 |
Contributor
Author
|
Hi @bsardo , Theses changes are urgently expected as it already has been released in Prebid.js 10.17.0 and 9.53.4 and in Prebid Server Java 3.36.0 |
Contributor
Author
|
Hi @bsardo @pm-isha-bharti , We’d love to get this aligned as soon as possible. |
pm-nikhil-vaidya
approved these changes
Jan 2, 2026
bsardo
reviewed
Jan 10, 2026
Collaborator
bsardo
left a comment
bsardo
left a comment
There was a problem hiding this comment.
@t-sormonte please see my last two comments.
Comment on lines
+270
to
+275
| params, ok := pubExt["params"].(map[string]interface{}) | ||
| if !ok { | ||
| params = make(map[string]interface{}) | ||
| pubExt["params"] = params | ||
| } | ||
| params["networkId"] = networkID |
Collaborator
There was a problem hiding this comment.
Is this right? You're not doing anything with params after modifying it.
Contributor
Author
There was a problem hiding this comment.
I was under the impression that since maps are reference types, extracting params here points to the same underlying data structure as pubExt['params']. So, modifying params update pubExt without needing a reassignment.
It seems to be working as expected in my tests, but if you find this flow unclear, please suggest me a clearer way i'll be happy to implement it.
Comment on lines
+140
to
+142
| if appDomain == "" { | ||
| appDomain = unknownValue | ||
| } |
Collaborator
There was a problem hiding this comment.
Is this correct? I see that when req.Site is set and domain is empty an error is recorded on lines 121-123 but no error is recorded here.
Contributor
Author
There was a problem hiding this comment.
the app_domain is helpful yet optional (a 'nice-to-have'). The critical mandatory field for Apps is actually the bundle, which we do validate and return an error for a few lines further down (lines 148-152). If you are ok with it, I'd prefer to keep the logic as is.
Contributor
Author
|
Hi @bsardo , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
We want to support new required query params when calling our SSP
The Java PR: prebid/prebid-server-java#4225