chore(deps): Upgrade jest version to 30.3.0#27657
Open
imsayari404 wants to merge 2 commits into
Open
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpgrades the Jest dependency in the presto-ui package to 30.3.0 and refreshes the yarn.lock to align transitive dependencies with the new Jest version. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider upgrading
jest-environment-jsdomto a compatible 30.x version as well, to avoid potential issues from mixing major Jest 30 with a Jest 29-specific environment package.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider upgrading `jest-environment-jsdom` to a compatible 30.x version as well, to avoid potential issues from mixing major Jest 30 with a Jest 29-specific environment package.
## Individual Comments
### Comment 1
<location path="presto-ui/src/package.json" line_range="36" />
<code_context>
"html-webpack-plugin": "^5.6.0",
"identity-obj-proxy": "^3.0.0",
- "jest": "^29.7.0",
+ "jest": "^30.3.0",
"jest-environment-jsdom": "^29.7.0",
"jquery": "3.7.1",
</code_context>
<issue_to_address>
**issue (bug_risk):** Align Jest-related package versions to avoid subtle breakages between 29.x and 30.x.
`jest` is now on 30.x while `jest-environment-jsdom` remains on 29.x. Mixing major versions can cause subtle runtime issues (config mismatches, environment differences, type issues). Please either keep everything on 29.x or upgrade all Jest-related packages to compatible 30.x versions.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
@imsayari404 Hope #27658 and this PR should go together ? I can see sourcery bot comment #27657 (comment) |
Contributor
Author
Yes @nishithakbhaskaran , I'm planning to bring those jest changes together in one single pr. |
c42e362 to
454d10d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
upgraded jest and jest-environment-jsdom from 29.7.0 to jest:30.3.0
Motivation and Context
Using a more recent version helps avoid potential vulnerabilities and ensures we aren't relying on outdated or unsupported code.
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
Summary by Sourcery
Build: