Skip to content

Conversation

liuliu-dev
Copy link
Contributor

Closes #4827

Changelog

Removed

Removed sx props from deprecated/UnderlineNav

Copy link

changeset-bot bot commented Aug 22, 2025

⚠️ No Changeset found

Latest commit: eff6409

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@liuliu-dev liuliu-dev added the skip changeset This change does not need a changelog label Aug 22, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 22, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@liuliu-dev liuliu-dev changed the title Remove xProp support from deprecated UnderlineNav Remove sxProp support from deprecated UnderlineNav Aug 22, 2025
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.02 KB (0%)
packages/react/dist/browser.umd.js 90.22 KB (0%)

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated sx prop support from the UnderlineNav component as part of cleanup efforts. The changes eliminate all sx-related functionality from the deprecated component and its documentation.

Key Changes

  • Removed SxProp type imports and sx function usage from the component
  • Cleaned up styled component definitions to remove sx integration
  • Updated documentation to remove sx prop references

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/deprecated/UnderlineNav/UnderlineNav.tsx Removes SxProp imports, sx function calls, and type annotations from component and styled components
packages/react/src/deprecated/UnderlineNav/UnderlineNav.docs.json Removes sx prop from component documentation

@hectahertz hectahertz added this pull request to the merge queue Aug 26, 2025
Merged via the queue into main with commit 0127afd Aug 26, 2025
50 of 51 checks passed
@hectahertz hectahertz deleted the liuliu/remove-sx-from-UnderlineNav-deprecated branch August 26, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants