Skip to content

Remove sxProp support from deprecated UnderlineNav #6653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
Merged

Remove sxProp support from deprecated UnderlineNav #6653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/react/src/deprecated/UnderlineNav/UnderlineNav.docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@
"name": "aria-label",
"type": "string",
"description": "Used to set the `aria-label` on the top level `<nav>` element."
},
{
"name": "sx",
"type": "SystemStyleObject",
"deprecated": true
}
],
"subcomponents": [
Expand Down Expand Up @@ -57,4 +52,4 @@
]
}
]
}
}
10 changes: 2 additions & 8 deletions packages/react/src/deprecated/UnderlineNav/UnderlineNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,13 @@ import type {To} from 'history'
import type React from 'react'
import styled from 'styled-components'
import {get} from '../../constants'
import type {SxProp} from '../../sx'
import sx from '../../sx'
import type {ComponentProps} from '../../utils/types'
import getGlobalFocusStyles from '../../internal/utils/getGlobalFocusStyles'

const ITEM_CLASS = 'PRC-UnderlineNav-item'
const SELECTED_CLASS = 'PRC-selected'

const UnderlineNavBase = styled.nav<SxProp>`
const UnderlineNavBase = styled.nav`
display: flex;
justify-content: space-between;
border-bottom: 1px solid ${get('colors.border.muted')};
Expand Down Expand Up @@ -39,8 +37,6 @@ const UnderlineNavBase = styled.nav<SxProp>`
.PRC-UnderlineNav-actions {
align-self: center;
}

${sx};
`

export type UnderlineNavProps = {
Expand Down Expand Up @@ -68,7 +64,7 @@ function UnderlineNav({actions, className, align, children, full, label, theme,
type StyledUnderlineNavLinkProps = {
to?: To
selected?: boolean
} & SxProp
}

const UnderlineNavLink = styled.a.attrs<StyledUnderlineNavLinkProps>(props => ({
className: clsx(ITEM_CLASS, props.selected && SELECTED_CLASS, props.className),
Expand Down Expand Up @@ -104,8 +100,6 @@ const UnderlineNavLink = styled.a.attrs<StyledUnderlineNavLinkProps>(props => ({
}

${getGlobalFocusStyles('-8px')};

${sx};
`

UnderlineNavLink.displayName = 'UnderlineNav.Link'
Expand Down
Loading