Skip to content

Try to avoid Java 8/11 mismatch issue #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
propensive wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Try to avoid Java 8/11 mismatch issue #1558

propensive wants to merge 3 commits into from

Conversation

@propensive
Copy link
Owner

@propensive propensive commented Sep 2, 2020

No description provided.

@propensive propensive linked an issue Sep 2, 2020 that may be closed by this pull request
Fury distribution built with Java 11 is incompatible with Java 8 #1557
Open
@propensive propensive requested a review from odisseus September 2, 2020 10:46
odisseus
odisseus requested changes Sep 4, 2020
View reviewed changes
Copy link
Collaborator

@odisseus odisseus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this doesn't fix the issue.

@propensive
Copy link
Owner Author

propensive commented Sep 4, 2020

I wonder if Scala considers the match to be a no-op rather than a cast because it's statically true already. I'll try casting it to an object first to see if that makes a difference.

Base automatically changed from master to main November 21, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odisseus odisseus odisseus requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fury distribution built with Java 11 is incompatible with Java 8

3 participants

@propensive @odisseus