Skip to content

Try to avoid Java 8/11 mismatch issue #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
propensive wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Try to avoid Java 8/11 mismatch issue #1558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59f24b4
Try to avoid Java 8/11 mismatch issue
propensive Sep 2, 2020
c8d3048
Print javac version
propensive Sep 4, 2020
5161b82
Further attempt to force cast on `Buffer`
propensive Sep 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
run: |
git describe --tags
make tmp/.version
echo $(javac -version)
make dist/fury
mv dist/fury.tar.gz dist/fury-$(head -n 1 tmp/.version).tar.gz
timeout-minutes: 10
Expand Down
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ tmp/lib/fury.jar: $(wildcard src/**/*.scala) tmp/.version
mkdir -p tmp/lib && \
printf "$(MK) Done\n" && \
printf "$(MK) Compiling Fury from source...\n" && \
javac -version && \
./fury build save --https --project fury --module frontend --output linear --path tmp/lib --fat-jar --disable-security-manager && \
mv tmp/lib/fury-frontend.jar "$@" && \
jar uf "$@" -C tmp .version && \
Expand Down
6 changes: 3 additions & 3 deletions src/ogdl/ogdl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
*/
package fury.ogdl

import java.nio.ByteBuffer
import java.nio.channels.FileChannel
import java.nio._, channels.FileChannel

import fury.io._
import fury.text._
Expand Down Expand Up @@ -153,7 +152,8 @@ object Ogdl {
val buffer = ByteBuffer.allocate(size)

inChannel.read(buffer)
buffer.flip()
val bufferObject: Any = buffer
bufferObject match { case buffer: Buffer => buffer.flip() }

buffer
} finally inChannel.close()
Expand Down