Repository navigation
Narrow gitleaks allowlist to fixture values; ignore 19 triaged history hits - #2340
Closed
remigiusz-antczak wants to merge 1 commit into
Closed
remigiusz-antczak wants to merge 1 commit into
remigiusz-antczak wants to merge 1 commit into
Conversation
…y hits .gitleaks.toml exempts only the fictional fixture values in the two secret test scripts instead of whole files. .gitleaksignore lists the fingerprints of the 19 remaining history hits, all triaged as fictional (placeholders, sha256 hashes, LLM bench outputs naming made-up APIs), so a history scan reports 0 findings. test_gitleaks_allowlist.sh asserts the 0-finding history scan in a git checkout. Tests: 303/311 test-ci-gates (8 = unchanged sandbox baseline fails, 2 skipped), test_gitleaks_allowlist 1/1 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by #2341, which adds the review fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2338; merge that first.
#2338 does not bring a full gitleaks history scan to zero: 19 findings remain, all under
docs/bench/. Each was triaged as fictional:YOUR_*placeholder tokens, sha256 hashes, and LLM bench outputs that name made-up APIs. Separately, #2338 allowlists two test scripts by whole-file path, so a real secret added to either file later would go unseen.Changes:
.gitleaks.toml: the two whole-file path entries for the test scripts become value regexes that match only their fictional fixture values (gitleaks 8.30.1 applies an AND allowlist's paths on their own, so a value regex is the narrowing that works)..gitleaksignore: fingerprints for exactly the 19 triaged history findings.scripts/test_gitleaks_allowlist.sh: a fresh probe key appended to a temp copy of each test script must still be detected, and a history scan of HEAD must report 0 findings.Verification:
gitleaks gitover the branch history with the committed config and ignore file reports 0 findings (it reported 19 before this change).test_gitleaks_allowlist.shpasses.test-ci-gates.shgives 303 pass / 8 fail / 2 skipped, and all 8 failures are the known sandbox-only baseline.🤖 Generated with Claude Code