Skip to content

Narrow gitleaks allowlist to fixture values; harden the allowlist guard - #2341

Closed
remigiusz-antczak wants to merge 2 commits into
mainfrom
fix/gitleaks-narrow-allowlist-3
Closed

remigiusz-antczak wants to merge 2 commits into
mainfrom
fix/gitleaks-narrow-allowlist-3

Conversation

@remigiusz-antczak

Copy link
Copy Markdown
Collaborator

Supersedes #2340 and adds the three review fixes.

  • .gitleaks.toml: the two whole-file test-script path entries become value regexes, so a real key added to either script is still caught. The comment now says these value regexes apply repo-wide.
  • .gitleaksignore: 19 fingerprints. Each one is a triaged, fictional history hit under docs/bench.
  • scripts/test_gitleaks_allowlist.sh:
    • scan_rel now counts a finding only when gitleaks exits 1 and its report holds an aws-access-token result. Any other exit code fails the test.
    • The script fails when gitleaks is missing and CI or REQUIRE_GITLEAKS=1 is set.
    • A shallow checkout skips only the history step, and says so.

Verified locally:

  • bash scripts/test_gitleaks_allowlist.sh prints PASS.
  • gitleaks git --log-opts=HEAD -c .gitleaks.toml --gitleaks-ignore-path .gitleaksignore prints "no leaks found".

Stacked on #2338. Retarget to main once #2338 merges.

🤖 Generated with Claude Code

remigiusz-antczak and others added 2 commits November 13, 2026 02:20
A root .gitleaks.toml extends the default rules and allowlists only the
synthetic secret-detector fixture files by anchored path regex (the
secret-leaks, secret-decoys and ledger files, the g1-matrix heldout
result files and two secret test scripts), taking the history scan from
91 hits to 0. Sibling files in those dirs stay scanned.

scripts/test_gitleaks_allowlist.sh requires an aws-access-token finding
for a fake key outside the allowlist, with the repo config and with the
default config as a control, and a clean scan of the fixture paths. It
skips when gitleaks is absent.

Tests: 303/311 (sandbox baseline unchanged; new guard passes)
No-Mechanism-Reason: config and test only, no skill prose changed

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…y hits

.gitleaks.toml exempts only the fictional fixture values in the two secret test scripts instead of whole files; its comment states the value regexes apply repo-wide. .gitleaksignore lists the fingerprints of the 19 remaining history hits, all triaged as fictional, so a history scan reports 0 findings. test_gitleaks_allowlist.sh asserts the 0-finding history scan (skipped on shallow checkouts), counts a probe as detected only on exit 1 plus an aws-access-token report (any other exit fails), and fails when gitleaks is missing under CI or REQUIRE_GITLEAKS=1.

Tests: test_gitleaks_allowlist 1/1 (rc 0); gitleaks history scan 0 findings

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@remigiusz-antczak

Copy link
Copy Markdown
Collaborator Author

Superseded by a single-commit recut on current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant