Skip to content

Narrow gitleaks allowlist to fixture values; harden the allowlist guard - #2351

Closed
remigiusz-antczak wants to merge 1 commit into
mainfrom
fix/gitleaks-narrow-allowlist-4
Closed

remigiusz-antczak wants to merge 1 commit into
mainfrom
fix/gitleaks-narrow-allowlist-4

Conversation

@remigiusz-antczak

Copy link
Copy Markdown
Collaborator

Supersedes #2341. Its base (#2338) was squash-merged, so the stacked branch conflicted. This is the same change as one commit on current main.

Tests: test_gitleaks_allowlist.sh PASS.

🤖 Generated with Claude Code

…y hits

.gitleaks.toml exempts only the fictional fixture values in the two secret test scripts instead of whole files; its comment states the value regexes apply repo-wide. .gitleaksignore lists the fingerprints of the 19 remaining history hits, all triaged as fictional, so a history scan reports 0 findings. test_gitleaks_allowlist.sh asserts the 0-finding history scan (skipped on shallow checkouts), counts a probe as detected only on exit 1 plus an aws-access-token report (any other exit fails), and fails when gitleaks is missing under CI or REQUIRE_GITLEAKS=1.

Tests: test_gitleaks_allowlist 1/1 (rc 0); gitleaks history scan 0 findings

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@remigiusz-antczak

Copy link
Copy Markdown
Collaborator Author

Superseded by a combined single-commit PR that also fixes the per-PR leg failure.

remigiusz-antczak added a commit that referenced this pull request Nov 13, 2026
.gitleaks.toml exempts only the fictional fixture values in the two secret test scripts instead of whole files; its comment states the value regexes apply repo-wide. .gitleaksignore lists the fingerprints of the 19 remaining history hits, all triaged as fictional, so a history scan reports 0 findings. test_gitleaks_allowlist.sh asserts the 0-finding history scan (skipped on shallow checkouts), counts a probe as detected only on exit 1 plus an aws-access-token report (any other exit fails), and fails when gitleaks is missing under REQUIRE_GITLEAKS=1.

Add a gitleaks job to ci.yml: full-history checkout without persisted credentials, gitleaks 8.30.1 installed from its release tarball and verified against a hardcoded sha256, then REQUIRE_GITLEAKS=1 bash scripts/test_gitleaks_allowlist.sh. The gates aggregate needs it; job permissions stay contents: read.

The guard is strict (missing gitleaks, shallow history or no .git FAILs) only when REQUIRE_GITLEAKS=1 is set. Keying strictness on CI broke the per-PR test legs, which run every test script with CI set but do not install gitleaks; they now SKIP it.

Supersedes #2351 and #2352.

Tests: 3/3 test_gitleaks_allowlist.sh runs (PASS with gitleaks; SKIP with CI=1 and no gitleaks; FAIL with REQUIRE_GITLEAKS=1 and no gitleaks). actionlint clean; size gate ok.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant