Repository navigation
Tool hub: route pmd (Java) and solhint (Solidity) through review_checks.sh - #2360
Merged
Merged
Conversation
Adds pmd (Java, one file per run, built-in category/java/security.xml ruleset only, SARIF, exit 4 = violations) and solhint (Solidity, one file per run, throwaway solhint:recommended config so a project .solhint.json that can load plugins is never read, SARIF). Both are NOT CHECKED when missing and not run on a crash, empty or wrong-shape output, a result with no location, or a non-zero exit with no row (PMD exit 5 and 1 are always not run). Flags come from the fetched PMD CLI reference and solhint README; solhint exit codes, the SARIF shapes, the PMD sarif format name and the bundled security ruleset path are marked unverified in tool-hub.md. Tests: 38/38 (hub-pmd-solhint 17, hub-tf-ansible 21) size-budget-raise: .claude/skills/deep-code-review/references/tool-hub.md 56593→57908 hub rows for pmd and solhint Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review fixes for the pmd and solhint routes. solhint now scans a throwaway tx.origin contract first and is not run unless it raises avoid-tx-origin, since the unverified extends value could otherwise load no rules and read as clean. The project-config test now changes a .sol with a plugin-bearing .solhint.json and fails if the tool is run without our --config. The "exit N with no row" message is asserted for pmd and solhint. Each new test fails with its guard removed (canary block, --config, message branch). No PMD canary: a bad ruleset path exits non-zero, which is already not run. Tests: 59/59 (hub-pmd-solhint 21, hub-tf-ansible 21, tool-hub 17) size-budget-raise: .claude/skills/deep-code-review/references/tool-hub.md 56593→58057 hub rows for pmd and solhint Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts in review_checks.sh (wired list, rubocop config gate and exit handling kept beside pmd and solhint), size-budgets.tsv (tool-hub.md set to the actual 59805 bytes), SHA256SUMS and the generated indexes (regenerated). 0 conflict markers. Tests: 63/63 (hub-pmd-solhint 21, hub-tf-ansible 21, hub-rb-cfn 12, tool-hub 9) size-budget-raise: .claude/skills/deep-code-review/references/tool-hub.md 58341→59805 hub rows for pmd and solhint Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pmd (changed Java files, built-in category/java/security.xml ruleset only, SARIF) and solhint (changed Solidity files, a throwaway solhint:recommended config passed with --config so a project .solhint.json and its plugins are never loaded, SARIF). Both are NOT CHECKED when missing, and not run on a crash, empty or wrong-shape output, or a non-zero exit with no row. solhint also scans a throwaway canary contract that uses tx.origin and is not run unless the avoid-tx-origin row appears, so a config that silently loads no rules cannot read as clean. A bad PMD ruleset path exits non-zero and is not run.
An independent review found that the solhint config could fail open and that the project-config test never ran solhint. Both are fixed, and each new test fails with its guard removed. The PMD sarif format name, the security.xml ruleset path, solhint exit codes and both SARIF shapes are unverified against real binaries and marked so in tool-hub.md; the tests use stub binaries.
Tests: 54/54 (hub-pmd-solhint 21, hub-tf-ansible 21, hub-rb-cfn 12); tool-hub 108 ok. The size gate and size ratchet pass.
🤖 Generated with Claude Code