Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/deep-code-review/INDEX.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ Generated by `scripts/skill_index.py` (do not hand-edit; rerun it after changing
| `references/testing-ui.md` | the target renders a UI or ships browser / E2E specs. | 4868 |
| `references/threat-modeling.md` | a change adds a trust boundary, an auth path, a data flow to a new party, an agent or tool capabili… | 2574 |
| `references/time-date-correctness.md` | reviewing anything that stores, computes, schedules, or renders timestamps, durations, recurring ev… | 4809 |
| `references/tool-hub.md` | a review should lean on external scanners via the tool hub (workflows, Python, Go, SBOM/lockfiles,… | 14585 |
| `references/tool-hub.md` | a review should lean on external scanners via the tool hub (workflows, Python, Go, SBOM/lockfiles,… | 14951 |
| `references/ux-components.md` | the target or diff renders one concept in more than one place: a shared component or design token,… | 7235 |
| `references/ux-dataviz.md` | the target or diff renders a chart, sparkline, heat-map or calendar grid, a KPI / metric delta, a c… | 2787 |
| `references/ux-gates.md` | a UI change is claimed verified on screenshot evidence, the project's auto-merge or CI policy gates… | 3756 |
Expand Down
2 changes: 2 additions & 0 deletions .claude/skills/deep-code-review/references/tool-hub.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ The agent sandbox denies installs and most network, so the owner provisions scan
| `devskim` | Multi-language source (Microsoft DevSkim, MIT), one changed file per run (`analyze --source-code` takes a file: `AnalyzeCommand.cs` has a single-file branch); rows from the SARIF results; wired only once installed | `devskim analyze --source-code FILE --file-format sarif`; SARIF to stdout (`-O` unset, `Console.Out`); without `-E` the exit is 0 whatever it finds, and `ExitCode.cs` makes errors negative (`CriticalError` -2, `ArgumentParsingError` -3), so any non-zero exit, empty output or a document without `runs[].results` is not run. `--file-format` is passed because the writer factory falls back to `text` when it is empty | verified for flags, exit codes and license (wiki Analyze Command; source at 7f8e5e24f6: options in `BaseAnalyzeCommandOptions.cs`, exit codes, `SarifWriter.cs`; README: MIT), not for the SARIF shape. Egress: no HTTP client, update or telemetry code in `DevSkim-DotNet` `*.cs` (grep); its NuGet dependencies (CommandLineParser, LibGit2Sharp, Sarif.Sdk, ApplicationInspector, Newtonsoft.Json) were not audited, so egress by a dependency is `unverified`; the SARIF help URIs are text. The SARIF shape (`runs[].results[]`) is stub-tested only, not verified: no real DevSkim output was fetched or run, so a real report may differ | route-only |
| `tfsec` | Terraform `.tf` files, one directory per changed file (tfsec scans directories, not files): run from the file's directory, rows kept only for the changed file; no module download; wired only once installed. Upstream says engineering attention moves to Trivy, so this row is a stopgap | `tfsec . --format sarif --no-colour --soft-fail --no-module-downloads --exclude-downloaded-modules`; `--soft-fail` suppresses the error code, so any non-zero exit, empty output or a document without `runs[].results` is not run | verified for flags only (usage guide and README, fetched 2026-11-13: `--format` lists sarif, `--soft-fail`, `--no-module-downloads`, `--exclude-downloaded-modules`, exit status non-zero on findings). Not verified: the SARIF shape and uri form (stub-tested only; a mismatched path form drops rows, never reads as a finding), egress and license. Rows overlap `checkov` and `kics` | route-only |
| `ansible-lint` | Ansible-looking YAML in a diff (a `roles/`, `tasks/`, `handlers/` or `playbooks/` path, or a file with `hosts:` and `tasks:` or `roles:`), changed files in one call; a changed `.ansible-lint` or `ansible.cfg` is `NOT CHECKED` (config is code); wired only once installed | `ansible-lint --offline --nocolor -q -f sarif FILES`; `--offline` disables requirements.yml installation and schema refresh. Exit codes are not documented (usage page), so a non-zero exit with no row is not run, never clean; a row for a file outside the changed list is also not run | verified for flags (usage page, fetched 2026-11-13: `--offline`, `-q`, `--nocolor`, `-f` choices include sarif). Not verified: exit codes, the SARIF shape, egress and license. The page contradicts itself on whether `-f json` is codeclimate or SARIF, so Perun passes `sarif` explicitly | route-only |
| `pmd` | Java `.java` files in a diff, one file per run; wired only once installed | `pmd check --no-cache --no-progress -R category/java/security.xml -f sarif -d FILE`: only PMD's built-in security ruleset, never a project ruleset (it can name custom classes). Exit 4 = violations, 5 = recoverable error (not run), anything else with no row is not run, never clean | verified for flags `check`, `-d`, `-R`, `-f`, `--no-cache`, `--no-progress` and the exit-code table (CLI reference, fetched 2026-11-13). Not verified: that `sarif` is the format name (the page links to the formats page only), that `category/java/security.xml` ships in the distribution, the SARIF shape, egress and license | route-only |
| `solhint` | Solidity `.sol` files in a diff, one file per run; wired only once installed | `solhint --config TMPCFG -f sarif --noPoster --disc FILE` with a throwaway config of `solhint:recommended`: a project `.solhint.json` can load plugins (code) and is never read. A canary scan of a throwaway tx.origin contract must raise avoid-tx-origin first, else not run (the unverified `extends` value could load no rules). A non-zero exit other than 1, or a non-zero exit with no row, is not run, never clean | verified for flags `-f` (formatters include sarif), `--config`, `--noPoster`, `--disc`, MIT license (README, fetched 2026-11-13). Not verified: exit codes, the SARIF shape, that `solhint:recommended` is a valid `extends` value, egress | route-only |
| `bundler-audit` | Ruby lockfiles: a changed `Gemfile.lock`, one per run, against the local ruby-advisory-db only; rows on the lockfile for each unpatched gem and insecure source; with no local db (`BUNDLER_AUDIT_DB` or `~/.local/share/ruby-advisory-db`) it is NOT CHECKED, because the tool would download one; wired only once installed | `bundle-audit check DIR --gemfile-lock Gemfile.lock --format json`, no `--update`; exit 1 means vulnerable (`cli.rb`: `exit(1) if report.vulnerable?`) but also every error, so exit 0 must give no rows, exit 1 must give rows, and anything else, empty output or a wrong shape is not run | verified for flags, `Database.exists?` and default paths, JSON shape (`Report#to_h`, `UnpatchedGem#to_h`, `InsecureSource#to_h`) and license GPL-3.0-or-later (README and source, fetched 2026-11-13); the binary name `bundle-audit` is from the README, not from the gemspec. Egress: the check downloads a db only when none exists (guarded here); no other network code was read. Stub-tested only: no real report was run | route-only |
| `cfn-lint` | CloudFormation templates: changed `.yaml .yml .json .template` files that name `AWSTemplateFormatVersion`, in one call; Error and Warning rows, Informational dropped; wired only once installed | `cfn-lint --format json -- FILES`; exit is a bitwise OR of 2 error, 4 warning, 8 informational (project docs), so 0, 2, 4, 6, 8, 10, 12 and 14 are runs and any other exit, empty output or a wrong shape is not run | verified for exit codes, `--format json` and license MIT-0 (repository page) and the JSON keys (`formatters/json.py`), fetched 2026-11-13. Egress: not audited, `unverified` (a spec download on a normal run was not ruled out). Stub-tested only | route-only |
| `rubocop` | Ruby: changed `.rb .rake .gemspec`, `Rakefile`, `Gemfile`, `config.ru`, in one call; rows are the `Security/*` cops only, from a run of all cops on the built-in default config (the project's `.rubocop.yml` can `require` code and is never loaded; a diff that changes a `.rubocop*.yml` is NOT CHECKED); wired only once installed | `rubocop --force-default-config --fail-level fatal --format json --cache false -- FILES`; exit 0 is the only run (1 means a fatal offense, 2 an abnormal end); any `error` or `fatal` non-Security offense such as `Lint/Syntax` (a file that did not parse, so its Security cops never ran), empty output, a wrong shape, a summary that disagrees with its files list, or an inspected-file count different from the files passed is not run; `--only Security` is not used because it hides `Lint/Syntax` | verified for exit codes and `--fail-level` existing (CLI reference), the JSON keys and severity levels (formatters page) and the Security cop names (cops page), fetched 2026-11-13. `unverified`: `--force-default-config` (an unsupported flag exits 2, so not run), `--fail-level fatal`, `--cache false`, and that explicit files bypass `AllCops: Exclude` (the inspected-count check turns a miss into not run); the Security cops `CompoundHash` and `IoMethods` are Pending and may stay off. Egress: not audited, `unverified`. Stub-tested only | route-only |
Expand Down
Loading
Loading