Fix TB, integrate VCS support#16
Merged
micprog merged 2 commits intopulp-platform:mainfrom May 21, 2025
Merged
Conversation
micprog
approved these changes
May 21, 2025
Member
micprog
left a comment
There was a problem hiding this comment.
Adjusted some minor things to ensure our internal flow works and tests this as well, thanks for making this compatible! LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to run the memory island testbench in VCS.
Added
test-vcsandtest-vcs-cleanbuild, run and clean the VCS simulation model.TestRegionbeing larger than the available memoryChanged
mismatchvector is undefined/X. Imo this should be counted as an error.Fixed
axi_memory_island_tb. Enqueueing and dequeueing is now done in a singlealwaysblock; Recalculation ofread_lenandwrite_lenvectors is now guaranteed to happen after the queues have settled.genvarassignstatements on dynamic arrays withalways_combblocks.