Fix abi3 wheel rejection in check_compatible() #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
check_compatible()
where some valid abi3 wheels were incorrectly rejected. Changes include:Implemented proper abi3 compatibility
Added version comparison logic that respects abi3 forward compatibility rules. This should only raise
ValueError
when wheels are truly incompatible.Moved
break
statement inside theif
condition to properly check all tags.Also improved error message consistency by showing all interpreter versions, similar to how ABI errors are shown.
This closes #245.