Skip to content

Fix abi3 wheel rejection in check_compatible() #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix abi3 wheel rejection in check_compatible() #246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47c4823
Fix wheel compatibility check logic
grden Aug 13, 2025
529d15f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions micropip/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,14 +190,31 @@ def platform_to_version(platform: str) -> str:
for tag in tags:
if tag.abi in abis:
abi_incompatible = False
break
break
if abi_incompatible:
abis_string = ",".join({tag.abi for tag in tags})
raise ValueError(
f"Wheel abi '{abis_string}' is not supported. Supported abis are 'abi3' and 'cp{version}'."
)

raise ValueError(f"Wheel interpreter version '{tag.interpreter}' is not supported.")
# Check interpreter compatibility
current_version = int(version)
for tag in tags:
try:
wheel_version = int(tag.interpreter.removeprefix("cp"))
# abi3: forward compatible (wheel_version <= current_version)
# non-abi3: exact match required (wheel_version == current_version)
if (tag.abi == "abi3" and wheel_version <= current_version) or (
tag.abi != "abi3" and wheel_version == current_version
):
return
except ValueError:
continue

interpreters_string = ",".join({tag.interpreter for tag in tags})
raise ValueError(
f"Wheel interpreter version '{interpreters_string}' is not supported."
)


def validate_constraints(
Expand Down