Remove event_loop fixture #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
- Coverage 90.84% 90.60% -0.25%
==========================================
Files 2 2
Lines 579 500 -79
Branches 77 64 -13
==========================================
- Hits 526 453 -73
+ Misses 32 30 -2
+ Partials 21 17 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ng requested in async fixtures.
…ng requested in async tests.
…licy. The warning was intended for user created loops and there shouldn't be anymore of them.
There's no longer a need to identify event loops provided by pytest-asyncio.
seifertm
force-pushed
the
remove-event-loop-fixture2
branch
from
b2280dc to
44162c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated event_loop fixture along with the associated warnings, such as the unclosed loop warning, the warning about requesting event_loop in async fixtures and tests, and the warning about multiple loops being requested in the same test.
This patch follows up the deprecation of the event_loop fixture in v0.22/v0.23 and represents a major cleanup of the pytest-asyncio code base.