-
Notifications
You must be signed in to change notification settings - Fork 160
Remove event_loop fixture #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove event_loop fixture #1106
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
- Coverage 90.84% 90.60% -0.25%
==========================================
Files 2 2
Lines 579 500 -79
Branches 77 64 -13
==========================================
- Hits 526 453 -73
+ Misses 32 30 -2
+ Partials 21 17 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ng requested in async fixtures.
…ng requested in async tests.
…licy. The warning was intended for user created loops and there shouldn't be anymore of them.
There's no longer a need to identify event loops provided by pytest-asyncio.
b2280dc
to
44162c4
Compare
Caused by the recent pytest-asyncio 1.0 release, which included pytest-dev/pytest-asyncio#1106. This is probably not the best fix - but it unbreaks things for now.
Caused by the recent pytest-asyncio 1.0 release, which included pytest-dev/pytest-asyncio#1106. This is probably not the best fix - but it unbreaks things for now.
Caused by the recent pytest-asyncio 1.0 release, which included pytest-dev/pytest-asyncio#1106. We need to pin to <1.0 until we upgrade all scriptworkers past python 3.8, I guess.
I'm not clear how event_loop should be replaced in sync test functions? I had previously assumed from the warnings, that event_loop was only deprecated for async functions. |
Hmm, we've got some rather awkward tests going on... We have things like:
But, aiohttp_client fixture is async, so it must be running in a loop context. So, if I create a new loop or something in this test, then I get problems like:
|
OK, seem to have resolved it with:
|
This PR removes the deprecated event_loop fixture along with the associated warnings, such as the unclosed loop warning, the warning about requesting event_loop in async fixtures and tests, and the warning about multiple loops being requested in the same test.
This patch follows up the deprecation of the event_loop fixture in v0.22/v0.23 and represents a major cleanup of the pytest-asyncio code base.