[slimtensor] Storage and SharedPtr for CPU owning mode #16383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff introduces the foundation for tensor storage management in the SlimTensor migration:
- util/SharedPtr.h - A lightweight, non-thread-safe shared pointer optimized for single-threaded tensor operations.
- core/Storage.h - The MaybeOwningStorage class that manages tensor data memory:
- DeviceTraits<CPU> specialization with allocate(), free(), memcpy() using malloc/free
- Owning mode for CPU device (CUDA and non-owning mode added later)
- Storage type alias as SharedPtr<MaybeOwningStorage>
- Move semantics for efficient resource transfer
- clone() and copy_() methods for data management
Differential Revision: [D89747980](https://our.internmc.facebook.com/intern/diff/D89747980/)
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16383
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 7 Unrelated FailuresAs of commit 169c8f2 with merge base 9ba1b5d ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This was referenced Dec 24, 2025
This PR needs a
|
This diff introduces the foundation for tensor storage management in the SlimTensor migration:
- util/SharedPtr.h - A lightweight, non-thread-safe shared pointer optimized for single-threaded tensor operations.
- core/Storage.h - The MaybeOwningStorage class that manages tensor data memory:
- DeviceTraits<CPU> specialization with allocate(), free(), memcpy() using malloc/free
- Owning mode for CPU device (CUDA and non-owning mode added later)
- Storage type alias as SharedPtr<MaybeOwningStorage>
- Move semantics for efficient resource transfer
- clone() and copy_() methods for data management
Differential Revision: [D89747980](https://our.internmc.facebook.com/intern/diff/D89747980/)
[ghstack-poisoned]
This was referenced Dec 26, 2025
This diff introduces the foundation for tensor storage management in the SlimTensor migration:
- util/SharedPtr.h - A lightweight, non-thread-safe shared pointer optimized for single-threaded tensor operations.
- core/Storage.h - The MaybeOwningStorage class that manages tensor data memory:
- DeviceTraits<CPU> specialization with allocate(), free(), memcpy() using malloc/free
- Owning mode for CPU device (CUDA and non-owning mode added later)
- Storage type alias as SharedPtr<MaybeOwningStorage>
- Move semantics for efficient resource transfer
- clone() and copy_() methods for data management
Differential Revision: [D89747980](https://our.internmc.facebook.com/intern/diff/D89747980/)
[ghstack-poisoned]
This was referenced Jan 5, 2026
JacobSzwejbka
requested changes
Jan 5, 2026
Contributor
JacobSzwejbka
left a comment
JacobSzwejbka
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
manuelcandales
approved these changes
Jan 9, 2026
This diff introduces the foundation for tensor storage management in the SlimTensor migration:
- util/SharedPtr.h - A lightweight, non-thread-safe shared pointer optimized for single-threaded tensor operations.
- core/Storage.h - The MaybeOwningStorage class that manages tensor data memory:
- DeviceTraits<CPU> specialization with allocate(), free(), memcpy() using malloc/free
- Owning mode for CPU device (CUDA and non-owning mode added later)
- Storage type alias as SharedPtr<MaybeOwningStorage>
- Move semantics for efficient resource transfer
- clone() and copy_() methods for data management
Differential Revision: [D89747980](https://our.internmc.facebook.com/intern/diff/D89747980/)
[ghstack-poisoned]
This diff introduces the foundation for tensor storage management in the SlimTensor migration:
- util/SharedPtr.h - A lightweight, non-thread-safe shared pointer optimized for single-threaded tensor operations.
- core/Storage.h - The MaybeOwningStorage class that manages tensor data memory:
- DeviceTraits<CPU> specialization with allocate(), free(), memcpy() using malloc/free
- Owning mode for CPU device (CUDA and non-owning mode added later)
- Storage type alias as SharedPtr<MaybeOwningStorage>
- Move semantics for efficient resource transfer
- clone() and copy_() methods for data management
Differential Revision: [D89747980](https://our.internmc.facebook.com/intern/diff/D89747980/)
[ghstack-poisoned]
This diff introduces the foundation for tensor storage management in the SlimTensor migration:
- util/SharedPtr.h - A lightweight, non-thread-safe shared pointer optimized for single-threaded tensor operations.
- core/Storage.h - The MaybeOwningStorage class that manages tensor data memory:
- DeviceTraits<CPU> specialization with allocate(), free(), memcpy() using malloc/free
- Owning mode for CPU device (CUDA and non-owning mode added later)
- Storage type alias as SharedPtr<MaybeOwningStorage>
- Move semantics for efficient resource transfer
- clone() and copy_() methods for data management
Differential Revision: [D89747980](https://our.internmc.facebook.com/intern/diff/D89747980/)
[ghstack-poisoned]
meta-codesync
bot
merged commit eed3c04
into
gh/gasoonjia/74/base
165 of 175 checks passed
Gasoonjia
added a commit
that referenced
this pull request
Jan 12, 2026
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #16383 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/74/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/74/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/73/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/74/orig Differential Revision: [D89747980](https://our.internmc.facebook.com/intern/diff/D89747980/) @diff-train-skip-merge --------- Co-authored-by: gasoonjia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff introduces the foundation for tensor storage management in the SlimTensor migration:
Differential Revision: D89747980