Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build gating on optimized_portable_kernels #9838

Merged
merged 13 commits into from
Apr 4, 2025
Merged

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Apr 2, 2025

If we don't need optimized kernels, we don't need optimized portable kernels.
Pull-Request-resolved: #9665

swolchok added 12 commits March 18, 2025 17:32
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9838

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 18fdc01 with merge base 40443a9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok
Copy link
Contributor Author

swolchok commented Apr 2, 2025

@manuelcandales apologies for the duplicate PR. having trouble with ghstack. you accepted this once already as #9665.

Base automatically changed from gh/swolchok/379/head to main April 2, 2025 20:11
@swolchok swolchok requested a review from lucylq as a code owner April 2, 2025 20:11
@swolchok swolchok merged commit ab0558b into main Apr 4, 2025
82 of 83 checks passed
@swolchok swolchok deleted the gh/swolchok/415/head branch April 4, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants