Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build gating on optimized_portable_kernels #9838

Merged
merged 13 commits into from
Apr 4, 2025
Merged

Fix build gating on optimized_portable_kernels #9838

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
31a49e0
Update
swolchok Mar 19, 2025
854c991
Update
swolchok Mar 19, 2025
b9c545f
Update
swolchok Mar 20, 2025
b61a8a2
Update
swolchok Mar 25, 2025
f659627
Update
swolchok Mar 25, 2025
9a93839
Update
swolchok Mar 26, 2025
7f57a19
Update
swolchok Mar 26, 2025
7086659
Update
swolchok Mar 28, 2025
ea9dc6f
Update
swolchok Mar 28, 2025
960315e
Update
swolchok Apr 2, 2025
20f3046
Update
swolchok Apr 2, 2025
3aa266d
Update
swolchok Apr 2, 2025
18fdc01
Merge branch 'main' into gh/swolchok/415/head
swolchok Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions kernels/portable/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,7 @@ gen_operators_lib(
# Portable kernels support optional parallelization (and, in the
# future, perhaps other performance features). If support is present,
# produce an optimized version.
set(BUILD_OPTIMIZED_PORTABLE_KERNELS EXECUTORCH_BUILD_PTHREADPOOL)

if(BUILD_OPTIMIZED_PORTABLE_KERNELS)
if(EXECUTORCH_BUILD_PTHREADPOOL AND EXECUTORCH_BUILD_KERNELS_OPTIMIZED)
add_library(optimized_portable_kernels ${_portable_kernels__srcs})
target_link_libraries(optimized_portable_kernels PRIVATE executorch)
target_link_libraries(optimized_portable_kernels PUBLIC extension_threadpool)
Expand Down
Loading