-
Notifications
You must be signed in to change notification settings - Fork 19
BECKHOFF minimal example motor #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Please fix the checks and do an rebase. |
|
fixed it |
…off Ek1100 and EL7031 # Conflicts: # machines/src/aquapath1/act.rs # machines/src/registry.rs # server/src/ethercat/setup.rs
912b096 to
ca80909
Compare
kraemr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all your .idea stuff you committed, stuff like this should never end up in a branch!
|
@kraemr we should add .idea to the gitignore |
|
He should |
|
@TheBest6337 please fix and merge this finally. We need the Motor example done. |
783dc37 to
ad05f82
Compare
TheBest6337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge Conflicts and other issues are fixed @Oshgnacknak i need your final review ^^
Oshgnacknak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There still is some German left
| Sometimes an error like this appears: | ||
|
|
||
| ```bash | ||
| .... | ||
| 37: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once | ||
| at /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library/alloc/src/boxed.rs:1985:9 | ||
| 38: std::sys::thread::unix::Thread::new::thread_start | ||
| at /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library/std/src/sys/thread/unix.rs:126:17 | ||
| 39: start_thread | ||
| 40: __clone3 | ||
| 14:10:46.906 INFO ThreadId(04) server::socketio::init: 167: Socket connected to namespace socket=FXdsVyRVGiN1nLXJ namespace=/main | ||
| ``` | ||
|
|
||
| Re-run the code until the QiTech UI appears. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo, this is pretty much useless to the reader. Rather show the EtherCAT init success message with the correct number of devices.
| Located in [machines/src/ethercat_beckhoff/](../../machines/src/ethercat_beckhoff/). | ||
|
|
||
| 1. **`mod.rs`**: Defines the `MotorTestMachine` struct and holds the state (driver wrapper, enabled state, target velocity). | ||
| 2. **`api.rs`**: Handles incoming JSON commands from the frontend (Enable/Disable, Set Velocity) via WebSockets/SocketIO. | ||
| 3. **`act.rs`**: The real-time control loop. It updates the `StepperVelocityEL70x1` driver wrapper in every cycle based on the current state. | ||
| 4. **`new.rs`**: Initializes the hardware. | ||
|
|
||
| ### Frontend (TypeScript/React) | ||
| Located in [electron/src/machines/ethercat_beckhoff/](../../electron/src/machines/ethercat_beckhoff/) and [electron/src/routes/routes.tsx](../../electron/src/routes/routes.tsx). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All three links are dead. I suggest using absolut paths. On github / is always points to the repository root
| max={1000} // Limit | ||
| step={1} | ||
| onChange={(val) => setVelocity(val)} | ||
| // Zeigt den Wert (hier ganze Zahl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls all comments in english
| import React from "react"; | ||
|
|
||
| export function TestMotorPage() { | ||
| // Hier ist der Zugriff erlaubt, weil diese Funktion erst später aufgerufen wird |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translate
| } from "@/client/socketioStore"; | ||
| import { MachineIdentificationUnique } from "@/machines/types"; | ||
|
|
||
| // ========== Event Schema (Muss zu StateEvent passen) ========== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translate
|
@Oshgnacknak can you take this issue over and finish it? |
minimal example motor of beckhoff ethercat 7031 0030 + ui