Skip to content

Conversation

@Hamid-el
Copy link
Contributor

minimal example motor of beckhoff ethercat 7031 0030 + ui

@TheBest6337
Copy link
Member

Please fix the checks and do an rebase.

@Hamid-el
Copy link
Contributor Author

Hamid-el commented Dec 15, 2025

fixed it

@kraemr kraemr self-requested a review December 17, 2025 13:29
Copy link
Collaborator

@kraemr kraemr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all your .idea stuff you committed, stuff like this should never end up in a branch!

@TheBest6337
Copy link
Member

@kraemr we should add .idea to the gitignore

@kraemr
Copy link
Collaborator

kraemr commented Dec 17, 2025

He should

@MilanVDB
Copy link
Collaborator

@TheBest6337 please fix and merge this finally. We need the Motor example done.

@MilanVDB MilanVDB requested a review from TheBest6337 December 24, 2025 09:41
@MilanVDB MilanVDB changed the title minimal example motor BECKHOFF minimal example motor Dec 25, 2025
Copy link
Member

@TheBest6337 TheBest6337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge Conflicts and other issues are fixed @Oshgnacknak i need your final review ^^

Copy link
Collaborator

@Oshgnacknak Oshgnacknak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There still is some German left

Comment on lines +180 to +193
Sometimes an error like this appears:

```bash
....
37: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
at /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library/alloc/src/boxed.rs:1985:9
38: std::sys::thread::unix::Thread::new::thread_start
at /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library/std/src/sys/thread/unix.rs:126:17
39: start_thread
40: __clone3
14:10:46.906 INFO ThreadId(04) server::socketio::init: 167: Socket connected to namespace socket=FXdsVyRVGiN1nLXJ namespace=/main
```

Re-run the code until the QiTech UI appears.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo, this is pretty much useless to the reader. Rather show the EtherCAT init success message with the correct number of devices.

Comment on lines +239 to +247
Located in [machines/src/ethercat_beckhoff/](../../machines/src/ethercat_beckhoff/).

1. **`mod.rs`**: Defines the `MotorTestMachine` struct and holds the state (driver wrapper, enabled state, target velocity).
2. **`api.rs`**: Handles incoming JSON commands from the frontend (Enable/Disable, Set Velocity) via WebSockets/SocketIO.
3. **`act.rs`**: The real-time control loop. It updates the `StepperVelocityEL70x1` driver wrapper in every cycle based on the current state.
4. **`new.rs`**: Initializes the hardware.

### Frontend (TypeScript/React)
Located in [electron/src/machines/ethercat_beckhoff/](../../electron/src/machines/ethercat_beckhoff/) and [electron/src/routes/routes.tsx](../../electron/src/routes/routes.tsx).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three links are dead. I suggest using absolut paths. On github / is always points to the repository root

max={1000} // Limit
step={1}
onChange={(val) => setVelocity(val)}
// Zeigt den Wert (hier ganze Zahl)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls all comments in english

import React from "react";

export function TestMotorPage() {
// Hier ist der Zugriff erlaubt, weil diese Funktion erst später aufgerufen wird
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translate

} from "@/client/socketioStore";
import { MachineIdentificationUnique } from "@/machines/types";

// ========== Event Schema (Muss zu StateEvent passen) ==========
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translate

@kraemr
Copy link
Collaborator

kraemr commented Jan 8, 2026

@Oshgnacknak can you take this issue over and finish it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants