Include some testing with Semeru 21 in our CI matrix #50651
Conversation
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
quarkus-bot
bot
added
the
area/infra-automation
|
@gsmet could you trigger full run? e.g. some minor change in root or bom pom.xml ... |
|
🎊 PR Preview 5847d4c has been successfully built and deployed to https://quarkus-pr-main-50651-preview.surge.sh/version/main/guides/
|
Also improves assertions and error messages.
Test failures are due to: eclipse-openj9/openj9#22812
It uses JFR and JFR is not available in the versions of Semeru we are testing.
| "Recent CPU utilization for the process as reported by the JVM.", "1", DOUBLE_GAUGE)); | ||
| jvmMetrics.add(new MetricToAssert("jvm.thread.count", "Number of executing platform threads.", "{thread}", LONG_SUM)); | ||
|
|
||
| // not supported on Semeru |
There was a problem hiding this comment.
@brunobat shouldn't otel docs mention these limitations (once we have semeru testing/support in) ?
Edit: I checked https://github.com/microprofile/microprofile-telemetry/blob/2.0/spec/src/main/asciidoc/metrics.adoc#required-metrics to be sure we don't have trouble on MicroProfile Telemetry front with Semeru. These metrics are not mandatory.
There was a problem hiding this comment.
@rsvoboda we already report that we don't support those OTel Metrics on native. Please check the list in here: https://quarkus.io/guides/opentelemetry-metrics#microprofile-2-0
There was a problem hiding this comment.
Native comment is not on these ...
if (!JdkUtil.isSemeru()) {
jvmMetrics.add(new MetricToAssert("jvm.cpu.limit", "", "1", LONG_SUM));
jvmMetrics.add(new MetricToAssert("jvm.cpu.longlock", "Long lock times", "s", HISTOGRAM));
jvmMetrics.add(new MetricToAssert("jvm.cpu.context_switch", "", "Hz", DOUBLE_SUM));
|
|
||
| if (!collector.isRecording()) { | ||
| LOGGER.warning( | ||
| "Recording JFR events is not supported by this VM, @ShouldPin and @ShouldNotPin annotations are not enforced."); |
There was a problem hiding this comment.
Something we should have in Quarkus docs too.
Probably in src/main/asciidoc/jfr.adoc and src/main/asciidoc/observability.adoc
Maybe a general guide with JDKs details / limits ?
There was a problem hiding this comment.
Yeah maybe but then I'm not really a fan of documenting the limitations of various JDKs, and updating them when new versions pop up.
3 participants
No description provided.