Skip to content

Include some testing with Semeru 21 in our CI matrix #50651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Include some testing with Semeru 21 in our CI matrix #50651

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2a5c1a1
Include some testing with Semeru 21 in our CI matrix
gsmet Oct 21, 2025
3307a77
Disable JFR tests as JFR is not supported by Semeru 21
gsmet Oct 30, 2025
1e98193
Drop useless tests created by the extension template
gsmet Oct 30, 2025
28ad2f5
Provide infrastructure to disable JUnit tests on Semeru
gsmet Oct 30, 2025
084798a
Disable RegisterForReflectionTestCase on Semeru
gsmet Oct 30, 2025
af11bc6
OpenTelemetry - Avoid checking metrics not existing on Semeru
gsmet Nov 4, 2025
74ed609
Reactive Routes - Disable tests failing on Semeru
gsmet Nov 4, 2025
f86b96f
Disable pinning detection for Virtual Threads on Semeru
gsmet Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 46 additions & 41 deletions integration-tests/opentelemetry/src/test/java/io/quarkus/it/opentelemetry/MetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
import static io.restassured.RestAssured.given;
import static java.net.HttpURLConnection.HTTP_OK;
import static java.util.concurrent.TimeUnit.SECONDS;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.assertj.core.api.Assertions.assertThat;
import static org.awaitility.Awaitility.await;
import static org.junit.jupiter.api.Assertions.assertEquals;

import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
Expand All @@ -19,6 +20,7 @@
import org.junit.jupiter.api.Test;

import io.opentelemetry.sdk.metrics.data.MetricDataType;
import io.quarkus.test.common.JdkUtil;
import io.quarkus.test.junit.QuarkusTest;
import io.restassured.common.mapper.TypeRef;

Expand Down Expand Up @@ -98,18 +100,17 @@ void testAllJvmMetrics() {

await().atMost(10, SECONDS).untilAsserted(() -> {
Set<String> allMetricNames = getAllMetricNames("jvm.");
assertThat(allMetricNames.size())
.withFailMessage("The jvm metrics are " + allMetricNames)
.isGreaterThanOrEqualTo(allMetrics.size());
assertThat(allMetricNames)
.containsAll(allMetrics.stream().map(MetricToAssert::name).toList());
});

allMetrics.forEach(metricToAssert -> {

// metric is there and has at least 1 reading
await().atMost(10, SECONDS)
.untilAsserted(() -> assertThat(getMetrics(metricToAssert.name()).size())
.withFailMessage("The metric " + metricToAssert.name())
.isGreaterThan(0));
.untilAsserted(() -> assertThat(getMetrics(metricToAssert.name()))
.withFailMessage("The metric " + metricToAssert.name() + " is not defined")
.hasSizeGreaterThan(0));

// skip assertions from flaky metrics
if (!metricToAssert.name().equals("jvm.memory.used_after_last_gc") &&
Expand Down Expand Up @@ -164,40 +165,44 @@ record MetricToAssert(String name, String description, String metricUnit, Metric
}

protected Set<MetricToAssert> getJvmMetricsToAssert() {
return Set.of(
// new MetricToAssert("http.server.request.duration", "Duration of HTTP server requests.", "s",
// HISTOGRAM), // just because we generate load with HTTP
new MetricToAssert("jvm.memory.committed", "Measure of memory committed.", "By", LONG_SUM),
new MetricToAssert("jvm.memory.used", "Measure of memory used.", "By", LONG_SUM),
// Not on native
new MetricToAssert("jvm.memory.limit", "Measure of max obtainable memory.", "By", LONG_SUM),
new MetricToAssert("jvm.memory.used_after_last_gc",
"Measure of memory used, as measured after the most recent garbage collection event on this pool.",
"By", LONG_SUM),
// not on native
new MetricToAssert("jvm.gc.duration", "Duration of JVM garbage collection actions.", "s",
HISTOGRAM),
new MetricToAssert("jvm.class.count", "Number of classes currently loaded.", "{class}",
LONG_SUM),
new MetricToAssert("jvm.class.loaded", "Number of classes loaded since JVM start.", "{class}",
LONG_SUM),
new MetricToAssert("jvm.class.unloaded", "Number of classes unloaded since JVM start.",
"{class}", LONG_SUM),
new MetricToAssert("jvm.cpu.count",
"Number of processors available to the Java virtual machine.", "{cpu}", LONG_SUM),
new MetricToAssert("jvm.cpu.limit", "", "1", LONG_SUM),
//jvm.system.cpu.utilization instead, on native
new MetricToAssert("jvm.cpu.time", "CPU time used by the process as reported by the JVM.", "s",
DOUBLE_SUM),
new MetricToAssert("jvm.cpu.recent_utilization",
"Recent CPU utilization for the process as reported by the JVM.", "1", DOUBLE_GAUGE),
new MetricToAssert("jvm.cpu.longlock", "Long lock times", "s", HISTOGRAM),
new MetricToAssert("jvm.cpu.context_switch", "", "Hz", DOUBLE_SUM),
// not on native
new MetricToAssert("jvm.network.io", "Network read/write bytes.", "By", HISTOGRAM),
new MetricToAssert("jvm.network.time", "Network read/write duration.", "s", HISTOGRAM),
new MetricToAssert("jvm.thread.count", "Number of executing platform threads.", "{thread}",
LONG_SUM));
Set<MetricToAssert> jvmMetrics = new HashSet<>();

// metrics.add(new MetricToAssert("http.server.request.duration", "Duration of HTTP server requests.", "s", HISTOGRAM)); // just because we generate load with HTTP
jvmMetrics.add(new MetricToAssert("jvm.memory.committed", "Measure of memory committed.", "By", LONG_SUM));
jvmMetrics.add(new MetricToAssert("jvm.memory.used", "Measure of memory used.", "By", LONG_SUM));
// Not on native
jvmMetrics.add(new MetricToAssert("jvm.memory.limit", "Measure of max obtainable memory.", "By", LONG_SUM));
jvmMetrics.add(new MetricToAssert("jvm.memory.used_after_last_gc",
"Measure of memory used, as measured after the most recent garbage collection event on this pool.",
"By", LONG_SUM));
// not on native
jvmMetrics.add(new MetricToAssert("jvm.gc.duration", "Duration of JVM garbage collection actions.", "s", HISTOGRAM));
jvmMetrics.add(new MetricToAssert("jvm.class.count", "Number of classes currently loaded.", "{class}", LONG_SUM));
jvmMetrics
.add(new MetricToAssert("jvm.class.loaded", "Number of classes loaded since JVM start.", "{class}", LONG_SUM));
jvmMetrics.add(
new MetricToAssert("jvm.class.unloaded", "Number of classes unloaded since JVM start.", "{class}", LONG_SUM));
jvmMetrics.add(new MetricToAssert("jvm.cpu.count", "Number of processors available to the Java virtual machine.",
"{cpu}", LONG_SUM));
// jvm.system.cpu.utilization instead, on native
jvmMetrics.add(
new MetricToAssert("jvm.cpu.time", "CPU time used by the process as reported by the JVM.", "s", DOUBLE_SUM));
jvmMetrics.add(new MetricToAssert("jvm.cpu.recent_utilization",
"Recent CPU utilization for the process as reported by the JVM.", "1", DOUBLE_GAUGE));
jvmMetrics.add(new MetricToAssert("jvm.thread.count", "Number of executing platform threads.", "{thread}", LONG_SUM));

// not supported on Semeru
Copy link
Member

@rsvoboda rsvoboda Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brunobat shouldn't otel docs mention these limitations (once we have semeru testing/support in) ?

Edit: I checked https://github.com/microprofile/microprofile-telemetry/blob/2.0/spec/src/main/asciidoc/metrics.adoc#required-metrics to be sure we don't have trouble on MicroProfile Telemetry front with Semeru. These metrics are not mandatory.

Copy link
Contributor

@brunobat brunobat Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsvoboda we already report that we don't support those OTel Metrics on native. Please check the list in here: https://quarkus.io/guides/opentelemetry-metrics#microprofile-2-0

Copy link
Member

@rsvoboda rsvoboda Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native comment is not on these ...

        if (!JdkUtil.isSemeru()) {
            jvmMetrics.add(new MetricToAssert("jvm.cpu.limit", "", "1", LONG_SUM));
            jvmMetrics.add(new MetricToAssert("jvm.cpu.longlock", "Long lock times", "s", HISTOGRAM));
            jvmMetrics.add(new MetricToAssert("jvm.cpu.context_switch", "", "Hz", DOUBLE_SUM));

if (!JdkUtil.isSemeru()) {
jvmMetrics.add(new MetricToAssert("jvm.cpu.limit", "", "1", LONG_SUM));
jvmMetrics.add(new MetricToAssert("jvm.cpu.longlock", "Long lock times", "s", HISTOGRAM));
jvmMetrics.add(new MetricToAssert("jvm.cpu.context_switch", "", "Hz", DOUBLE_SUM));

// not on native
jvmMetrics.add(new MetricToAssert("jvm.network.io", "Network read/write bytes.", "By", HISTOGRAM));
jvmMetrics.add(new MetricToAssert("jvm.network.time", "Network read/write duration.", "s", HISTOGRAM));
}

return jvmMetrics;
}

private Double getLastReading(MetricToAssert metricToAssert) {
Expand Down