-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bold preview #176
Open
nandap4790
wants to merge
8
commits into
master
Choose a base branch
from
bold-preview
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bold preview #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onents into bold-preview
…onents into bold-preview
nandap4790
commented
Apr 23, 2021
@@ -36,20 +36,23 @@ export function WithPreview(klazz, updateData) { | |||
} | |||
|
|||
componentDidMount() { | |||
global.addEventListener("message", event => { | |||
if (event.data && event.data.action == 'reloadStory' && event.data.story) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The bold issue occurs only for whoever is using the WithPreview component from quintype-node-components.
- Initially we were getting
event.data.action
asreloadStory
, but as we debugged we are now gettingsendStoryToIframe
. - Then it is recommended to test with this version.
- We need to now test if the preview is working on tq/malibu for both home and story.
- If it works, we will have to confirm with the platform team if
event.data.action
is set tosendStoryToIframe
.(Akshay Gupta and Prabu has some context on this) - If not there are 2 solutions:
a. Platform will have to debug from where thesendStoryToIframe
is coming from.
b. We will have to check and validate if onlyevent.data && event.data.story
checks are sufficient.(Confirm with Ram/Amogh)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include the summary of the change made. Please include the required context here. Please include the issue reference for the fix and the dependencies reference for the change.
Fixes # (issue-reference)
Dependencies # (dependency-issue-reference)
Documentation # (link to the corresponding documentation changes)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: