Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold preview #176

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Bold preview #176

wants to merge 8 commits into from

Conversation

nandap4790
Copy link
Contributor

Description

Please include the summary of the change made. Please include the required context here. Please include the issue reference for the fix and the dependencies reference for the change.

Fixes # (issue-reference)

Dependencies # (dependency-issue-reference)

Documentation # (link to the corresponding documentation changes)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test Case A
  • Test Case B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@@ -36,20 +36,23 @@ export function WithPreview(klazz, updateData) {
}

componentDidMount() {
global.addEventListener("message", event => {
if (event.data && event.data.action == 'reloadStory' && event.data.story) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The bold issue occurs only for whoever is using the WithPreview component from quintype-node-components.
  2. Initially we were getting event.data.action as reloadStory, but as we debugged we are now getting sendStoryToIframe .
  3. Then it is recommended to test with this version.
  4. We need to now test if the preview is working on tq/malibu for both home and story.
  5. If it works, we will have to confirm with the platform team if event.data.action is set to sendStoryToIframe.(Akshay Gupta and Prabu has some context on this)
  6. If not there are 2 solutions:
    a. Platform will have to debug from where the sendStoryToIframe is coming from.
    b. We will have to check and validate if only event.data && event.data.story checks are sufficient.(Confirm with Ram/Amogh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants