-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bold preview #176
Open
nandap4790
wants to merge
8
commits into
master
Choose a base branch
from
bold-preview
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bold preview #176
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
15f8b74
action changed from reloadStory to sendStoryToIFrame
phaneendraandukuri 1a5b9e6
chore(release): 2.27.3-bold-preview.0
nandap4790 dd20885
action changed from reloadStory to sendStoryToIframe
phaneendraandukuri ccf9796
Merge branch 'bold-preview' of github.com:quintype/quintype-node-comp…
phaneendraandukuri d98bb28
chore(release): 2.27.3-bold-preview.1
nandap4790 cdeb4e6
remove data.action check
phaneendraandukuri 6dca6ed
Merge branch 'bold-preview' of github.com:quintype/quintype-node-comp…
phaneendraandukuri ea3fae1
chore(release): 2.27.3-bold-preview.2
nandap4790 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
event.data.action
asreloadStory
, but as we debugged we are now gettingsendStoryToIframe
.event.data.action
is set tosendStoryToIframe
.(Akshay Gupta and Prabu has some context on this)a. Platform will have to debug from where the
sendStoryToIframe
is coming from.b. We will have to check and validate if only
event.data && event.data.story
checks are sufficient.(Confirm with Ram/Amogh)