[ci] stop verifying python 3.9 wheels #58365
Conversation
we will stop releasing them Signed-off-by: Lonnie Liu <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes Python 3.9 from the CI configurations for wheel verification, aligning with the plan to stop releasing wheels for this version. The changes in .buildkite/release-automation/verify-macos-wheels.sh and .buildkite/release-automation/wheels.rayci.yml are correct and achieve this goal. I've added one suggestion to improve the maintainability of the YAML configuration by de-duplicating the Python version lists. Overall, the PR is in good shape.
| matrix: | ||
| - "3.9" | ||
| - "3.10" | ||
| - "3.11" | ||
| - "3.12" |
There was a problem hiding this comment.
This list of Python versions is duplicated later in this file for the GPU wheel verification step (lines 59-62). To improve maintainability and avoid having to update the versions in multiple places in the future, consider defining this list once using a YAML anchor and referencing it in both matrices. 1
For example:
# At the top of the file or before its first use
x-python-versions: &python-versions
- "3.10"
- "3.11"
- "3.12"
# ...
matrix: *python-versionsRules References
Footnotes
-
To improve maintainability, avoid duplicating configuration or code. The Don't Repeat Yourself (DRY) principle helps in reducing redundancy, which simplifies updates and reduces the chance of inconsistencies. ↩
author Lonnie Liu <[email protected]> 1762143156 -0800 committer harshit <[email protected]> 1762519796 +0000 parent c4f0c24 author Lonnie Liu <[email protected]> 1762143156 -0800 committer harshit <[email protected]> 1762519679 +0000 [wheel] stop uploading python 3.9 wheels on release (#58363) python 3.9 is now out of the support window all using python 3.12 wheel names for unit testing Signed-off-by: Lonnie Liu <[email protected]> [ci] stop verifying python 3.9 wheels (#58365) we will stop releasing them Signed-off-by: Lonnie Liu <[email protected]> [bazel] rename python runtime to py39 runtime (#58362) and move them into bazel dir. getting ready for python version upgrade Signed-off-by: Lonnie Liu <[email protected]> add template for async inf Signed-off-by: harshit <[email protected]> minor changes Signed-off-by: harshit <[email protected]> template for async inf Signed-off-by: harshit <[email protected]> fix tests Signed-off-by: harshit <[email protected]> fix tests Signed-off-by: harshit <[email protected]> fix tests Signed-off-by: harshit <[email protected]> fix tests Signed-off-by: harshit <[email protected]> fix tests Signed-off-by: harshit <[email protected]>
we will stop releasing them Signed-off-by: Lonnie Liu <[email protected]>
we will stop releasing them