Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/release-automation/verify-macos-wheels.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ set -x
# TODO(#54047): Python 3.13 is skipped due to the bug
# we should re-enable it when the bug is fixed.

PYTHON_VERSIONS=("3.9" "3.10" "3.11" "3.12")
PYTHON_VERSIONS=("3.10" "3.11" "3.12")
BAZELISK_VERSION="v1.16.0"

export USE_BAZEL_VERSION="${USE_BAZEL_VERSION:-6.5.0}"
Expand Down
2 changes: 0 additions & 2 deletions .buildkite/release-automation/wheels.rayci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ steps:
- export RAY_COMMIT="$RAY_COMMIT"
- bash -i .buildkite/release-automation/verify-linux-wheels.sh
matrix:
- "3.9"
- "3.10"
- "3.11"
- "3.12"
Comment on lines 37 to 40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This list of Python versions is duplicated later in this file for the GPU wheel verification step (lines 59-62). To improve maintainability and avoid having to update the versions in multiple places in the future, consider defining this list once using a YAML anchor and referencing it in both matrices. 1

For example:

# At the top of the file or before its first use
x-python-versions: &python-versions
  - "3.10"
  - "3.11"
  - "3.12"

# ...

    matrix: *python-versions

Rules References

Footnotes

  1. To improve maintainability, avoid duplicating configuration or code. The Don't Repeat Yourself (DRY) principle helps in reducing redundancy, which simplifies updates and reduces the chance of inconsistencies.

Expand All @@ -58,7 +57,6 @@ steps:
- export RAY_COMMIT="$RAY_COMMIT"
- bash -i .buildkite/release-automation/verify-linux-wheels.sh
matrix:
- "3.9"
- "3.10"
- "3.11"
- "3.12"
Expand Down