adding gift card support for underarmour

[nkttiwari]

Note :- Please follow the below points while attaching test cases document link below:

- If label Tested is added then test cases document URL is mandatory.

- Link added should be a valid URL and accessible throughout the org.

- If the branch name contains hotfix / revert by default the BVT workflow check will pass.

Test Case Document URL
Please paste test case document link here....

[lbajsarowicz]

⚠️ I found potential bug in promotions handling.

• Missing handling for translations.

[lbajsarowicz]

This can be simplified with:

Suggested change

	$giftCardDiscountAmount = 0;
	//Check if the customer has applied GiftCards
	if($quote->getMageworxGiftcardsAmount()) {
	$giftCardDiscountAmount = abs($quote->getMageworxGiftcardsAmount());
	}
	// Check if the customer has applied GiftCards
	$giftCardDiscountAmount = !empty($quote->getMageworxGiftcardsAmount())
	? abs($quote->getMageworxGiftcardsAmount())
	: 0;

[lbajsarowicz]

When there's no Gift Card Discount applied, I believe the $promotions should be empty

Suggested change

	if($giftCardDiscountAmount > 0)
	{
	$totalAmount = $totalAmount - $giftCardDiscountAmount;
	$giftCardDiscount = [
	'gift_card_discount'=> $giftCardDiscountAmount,
	];
	$orderNotes = array_merge($orderNotes, $giftCardDiscount);
	}
	$promotions = [
	'type' => 'gift_card',
	'code' => 'gift_card_number',
	'value' => $giftCardDiscountAmount,
	'description' => 'applied',
	];
	$promotions = [];
	if($giftCardDiscountAmount > 0)
	{
	$totalAmount = $totalAmount - $giftCardDiscountAmount;
	$giftCardDiscount = [
	'gift_card_discount'=> $giftCardDiscountAmount,
	];
	$orderNotes = array_merge($orderNotes, $giftCardDiscount);
	$promotions = [
	'type' => 'gift_card',
	'code' => 'gift_card_number',
	'value' => $giftCardDiscountAmount,
	'description' => 'applied',
	];
	}

[lbajsarowicz]

Have you considered using __() for translation support?