Fix for image data urls (Fixes #575) #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
omersaleem
changed the title
michielvandergeest
approved these changes
Sep 8, 2025
Contributor
michielvandergeest
left a comment
michielvandergeest
left a comment
There was a problem hiding this comment.
Thank @omersaleem! LGTM
Contributor
|
Thanks, could that be cherry picked in the RTL branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575
A change that was added to check Image src urls caused a regression when using image data urls - this has broken our app as we use this feature to display QR codes generated on the fly.
This fix preserves the original check but ignores these checks for data urls (that begin with
data:.This has broken our My Sky app and we have had to revert to an older version of Lightning core until this is released.