Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/platforms/browser/WebPlatform.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,9 @@ export default class WebPlatform {
}

// URL can start with http://, https://, and //
// (Ignore data URLs that start with data:)
const separatorPos = src.indexOf('//');
if (separatorPos !== 0 && separatorPos !== 5 && separatorPos !== 6) {
if (!src.startsWith('data:') && separatorPos !== 0 && separatorPos !== 5 && separatorPos !== 6) {
return cb("Invalid image URL");
}

Expand Down
27 changes: 27 additions & 0 deletions src/platforms/browser/WebPlatform.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,33 @@ describe('WebPlatform', () => {
expect(mockImage.cancel).toHaveBeenCalledTimes(1);
});

it('loads data URLs', () => {
const mockImage = {
cancel: vi.fn()
};

webPlatform._imageWorker = {
create: vi.fn().mockReturnValue(mockImage)
};

const opts = {
src: 'data:image/png;base64;1234567890ABCDEFcoolPNGdude'
}

const cancelCb = webPlatform.loadSrcTexture(opts, () => {
throw 'Should not happen'
});

expect(webPlatform._imageWorker.create).toHaveBeenCalledWith(opts.src);
expect(typeof mockImage.onLoad).toBe('function');
expect(typeof mockImage.onError).toBe('function');
expect(mockImage.cancel).toHaveBeenCalledTimes(0);

cancelCb();

expect(mockImage.cancel).toHaveBeenCalledTimes(1);
});

it('fails with relative URLs', () => {
const mockImage = {
cancel: vi.fn()
Expand Down