updated home styling #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for rne-playground processing. Building with commit 6cbf6a6 https://app.netlify.com/sites/rne-playground/deploys/60596c8ec0877c0008cdfd99 |
|
Thanks for the PR, but it's not recommended to use direct css due to name collisions. |
@pranshuchittora done👍 |
src/pages/home/home.module.css
Outdated
| .divider{ | ||
| margin: 3vh 0; | ||
| } | ||
| .grid{ |
There was a problem hiding this comment.
Can you name them more specifically
src/pages/home/home.module.css
Outdated
| } | ||
|
|
||
|
|
||
| .paper{ |
|
All class names seems to generic, it would be great if they are more specific |
@pranshuchittora i have fixed the style naming, but the checks are failing. I don't know why? |
|
Pls pull the new changes and resolve the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issue #3:
changed inline styling in home page to external styling