code fixes 1#31
Conversation
|
Deploy preview for rne-playground ready! Built with commit 75261b8 |
thanks.. yeah i have mentioned it now |
src/content/Avatar/index.jsx
Outdated
| const Content = lazy(() => importMDX("./avatar.mdx")); | ||
| class App extends Component { | ||
| render() { | ||
| export default function App(){ |
There was a problem hiding this comment.
Can you convert this to a named function. Default export of anonymous funcs is not recommended
https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-anonymous-default-export.md
src/pages/home/index.jsx
Outdated
| export default HomePage; | ||
|
|
||
| const FeatureCard = (props) => { | ||
| const FeatureCard = ({banner,title,content}) => { |
There was a problem hiding this comment.
This will be fixed after TS migration of this repo
There was a problem hiding this comment.
Undo these changes as requested
src/content/Badge/index.jsx
Outdated
| @@ -1,5 +1,5 @@ | |||
| import React, { lazy, Suspense } from "react"; | |||
| import { importMDX } from "mdx.macro"; | |||
| import importMDX from "mdx.macro"; | |||
There was a problem hiding this comment.
Incorrect, breaking the build.
react_devtools_backend.js:2430 ReferenceError: importMDX is not defined
at index.jsx:7
at 2.b56122d9.chunk.js:sourcemap:2
at ys (2.b56122d9.chunk.js:sourcemap:2)
at ul (2.b56122d9.chunk.js:sourcemap:2)
at sl (2.b56122d9.chunk.js:sourcemap:2)
at Zs (2.b56122d9.chunk.js:sourcemap:2)
at 2.b56122d9.chunk.js:sourcemap:2
at t.unstable_runWithPriority (2.b56122d9.chunk.js:sourcemap:2)
at Ui (2.b56122d9.chunk.js:sourcemap:2)
at Gi (2.b56122d9.chunk.js:sourcemap:2)
There was a problem hiding this comment.
is importMDX defined for other files?
@Devesh21700Kumar pls check the build from your changes.
|
|
@pranshuchittora Hey, Thanks for the review.. I've fixed the Build errors and have made the export named instead of default.. please do check and merge if it is not giving any errors |
|
@pranshuchittora I have reverted them now. Please check and merge. Thanks |
|
Pls resolve the conflicts |
3 participants
1).restructured props in pages/home
2).relative imports from directories external to /src are not allowed in modern react versions so fixed them to adapt with latest versions
3).made Avatar a functional component
for issue #3