orchestrator: replace businessKey#306
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
|
this is to be merged after we have an official OSL with the required changes (apache/incubator-kie-kogito-runtimes#3810.) |
| category: instance.category, | ||
| state: instance.state, | ||
| description: instance.description, | ||
| businessKey: instance.businessKey, |
There was a problem hiding this comment.
Why isn't there assessmentInstanceId defined here? like for https://github.com/redhat-developer/rhdh-plugins/pull/306/files#diff-863d661b58ddfc134554cea4bf31465f4720f1c56accfc594368331bf13c52ccR145
Is it because the returned object was only used to send the request and as of know the buisnessKey is not given anymore but fetched directly from the DI so we do not need it?
| duration: duration, | ||
| // @ts-ignore | ||
| workflowdata: variables?.workflowdata, | ||
| assessmentInstanceId: variables?.orchestratorAssessmentInstanceId as string, |
There was a problem hiding this comment.
where is assessmentInstanceId used in the front-end? I am asking as now the request will return this new variable instead of businessKey but I do not see any changes on the FE plugin
There was a problem hiding this comment.
this is why it is a draft PR. we need to wait for sonata to support it in official release and then someone will have to change the FE
christoph-jerolimov
changed the title
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
ydayagi
requested review from
batzionb,
gciavarrini and
mareklibra
as code owners
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
ydayagi
force-pushed
the
flpath1926
branch
3 times, most recently
from
d90b066 to
a35467d
Compare
ydayagi
force-pushed
the
flpath1926
branch
2 times, most recently
from
c5ec28c to
5eb1456
Compare
FLPATH-1926 https://issues.redhat.com/browse/FLPATH-1926 Signed-off-by: Yaron Dayagi <ydayagi@redhat.com>
|
FLPATH-1926 https://issues.redhat.com/browse/FLPATH-1926 Signed-off-by: Yaron Dayagi <ydayagi@redhat.com>
FLPATH-1926 https://issues.redhat.com/browse/FLPATH-1926 Signed-off-by: Yaron Dayagi <ydayagi@redhat.com>
3 participants
FLPATH-2428
https://issues.redhat.com/browse/FLPATH-2428
Hey, I just made a Pull Request!
✔️ Checklist